From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753215AbcH3S6t (ORCPT <rfc822;w@1wt.eu>);
        Tue, 30 Aug 2016 14:58:49 -0400
Received: from mail-oi0-f53.google.com ([209.85.218.53]:34705 "EHLO
        mail-oi0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751166AbcH3S6s (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 30 Aug 2016 14:58:48 -0400
MIME-Version: 1.0
In-Reply-To: <CAMz4kuLCU=vP7tuhh2a9XRk1KLKfkmJeW8YqXWDZVODtTrKqfA@mail.gmail.com>
References: <27d8c8be532b025a1e68d710ff539b8923c9d4cb.1471839665.git.baolin.wang@linaro.org>
 <CAMz4kuLCU=vP7tuhh2a9XRk1KLKfkmJeW8YqXWDZVODtTrKqfA@mail.gmail.com>
From: John Stultz <john.stultz@linaro.org>
Date: Tue, 30 Aug 2016 11:58:46 -0700
Message-ID: <CALAqxLXdeQ5snMbCxZRowu_BRDA+DXKLR3YE39tB7NDrAzmpig@mail.gmail.com>
Subject: Re: [PATCH v3] time: alarmtimer: Add the trcepoints for alarmtimer
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, Mark Brown <broonie@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 30, 2016 at 4:50 AM, Baolin Wang <baolin.wang@linaro.org> wrote:
> Hi,
>
> On 22 August 2016 at 12:23, Baolin Wang <baolin.wang@linaro.org> wrote:
>> For system debugging, we usually want to know who sets one alarm timer, the
>> time of the timer, when the timer started and fired and so on. Thus adding
>> tracepoints can help us trace the alarmtimer information.
>>
>> For example, when we debug the system supend/resume, if the system is always
>> resumed by RTC alarm, we can find out which process set the alarm timer to
>> resume system by below trace log:
>>
>> ......
>> Binder:2976_6-3473  [005] d..2  1076.587732: alarmtimer_start: process:Binder:2976_6
>> alarmtimer type:ALARM_BOOTTIME expires:1234154000000 time: 1970-1-1 0:20:35
>>
>> Binder:2976_7-3480  [002] d..2  1076.592707: alarmtimer_cancel: process:Binder:2976_7
>> alarmtimer type:ALARM_BOOTTIME expires:1325463060000000000 time: 2012-1-2 0:11:0
>>
>> Binder:2976_7-3480  [002] d..2  1076.592731: alarmtimer_start: process:Binder:2976_7
>> alarmtimer type:ALARM_BOOTTIME expires:1325378040000000000 time: 2012-1-1 0:34:0
>>
>> system_server-2976  [003] d..2  1076.605587: alarmtimer_cancel: process:system_server
>> alarmtimer type:ALARM_BOOTTIME expires:1234154000000 time: 1970-1-1 0:20:35
>>
>> system_server-2976  [003] d..2  1076.605608: alarmtimer_start: process:system_server
>> alarmtimer type:ALARM_BOOTTIME expires:1234155000000 time: 1970-1-1 0:20:35
>>
>> system_server-3000  [002] ...1  1087.737565: alarmtimer_suspend: alarmtimer type:ALARM_BOOTTIME
>> expires time: 2012-1-1 0:34:0
>> ......
>>
>> From the trace log, we can find out the 'Binder:2976_7' process set one alarm
>> timer which resumes the system.
>
> Do you have any comments about this patch? Thanks.

No objection from me. I'll queue it for testing.

thanks
-john