From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754616AbaGUWAV (ORCPT ); Mon, 21 Jul 2014 18:00:21 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:47273 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752070AbaGUWAU (ORCPT ); Mon, 21 Jul 2014 18:00:20 -0400 MIME-Version: 1.0 In-Reply-To: References: From: Andy Lutomirski Date: Mon, 21 Jul 2014 14:59:58 -0700 Message-ID: Subject: Re: [PATCH] x86_32, entry: store badsys error code in %eax To: Sven Wegener Cc: "H. Peter Anvin" , Richard Weinberger , X86 ML , Eric Paris , Linux Kernel , Steven Rostedt , Borislav Petkov , =?UTF-8?Q?Toralf_F=C3=B6rster?= , stable , Roland McGrath , Josh Boyer Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 20, 2014 at 2:33 PM, Sven Wegener wrote: > Commit 554086d ("x86_32, entry: Do syscall exit work on badsys > (CVE-2014-4508)") introduced a subtle regression in the x86_32 syscall > entry code, resulting in syscall() not returning proper errors for > non-existing syscalls on CPUs not supporting the sysenter feature. s/not supporting/supporting/ That means that this is IMO much worse than the other way around: all newish 32-bit systems are affected. Other than the typo and the missing Cc: stable: Reviewed-and-tested-by: Andy Lutomirski --Andy