From: Andy Lutomirski <luto@amacapital.net>
To: Peter Jones <pjones@redhat.com>
Cc: Matt Fleming <matt@console-pimps.org>,
"Kweh, Hock Leong" <hock.leong.kweh@intel.com>,
Sam Protsenko <semen.protsenko@linaro.org>,
Ming Lei <ming.lei@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Ong, Boon Leong" <boon.leong.ong@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>
Subject: Re: Re: [PATCH v2 3/3] efi: Capsule update with user helper interface
Date: Tue, 10 Mar 2015 08:51:59 -0700 [thread overview]
Message-ID: <CALCETrUDuTt_BK1JSFU=_EEujpm1ekzmkte-c3vxuRW7hWPUPQ@mail.gmail.com> (raw)
In-Reply-To: <20150310154000.GD1208@fenchurch.internal.datastacks.com>
On Tue, Mar 10, 2015 at 8:40 AM, Peter Jones <pjones@redhat.com> wrote:
>
>> >> So, for the sysfs interface, let's not allow loading from /lib. Let's
>> >> not require a userland tool. Let's just do,
>> >>
>> >> # echo /path/to/my/awesome/capsule.bin > /sys/../capsule
>> >
>> >>
>> >> and be done with it.
>> >>
>> >> Hmmm?
>> >
>> > I assume you're implying a) the capsule header with the guid is embedded
>> > in the .bin there already, and b) one contiguous write(2) with error
>> > reporting coming through something like vars.c's efi_status_to_err()?
>> >
>> > If so, yes, I prefer this API.
>> >
>>
>> Is using a char device really so bad? I have a "simple_char" that
>> makes this really easy that's pending review.
>
> As long as there's straightforward propagation of the EFI_STATUS return
> from UpdateCapsule() back, sysfs file vs char device makes very little
> difference to me. Either way it's open(), write(), close(). Using the
> runtime firmware upload interface designed for wifi and scsi devices is
> the part I don't really like.
>
I'm not 100% happy with write(2) (which is all we have in sysfs) for
two reasons:
1. If we write a file name, eww. That's more complicated, requires
temporary files, has annoying mount namespace issues, etc.
2. If we write the full contents, we need to do it in a single call to
write. That means that we can't use cat, which mostly defeats the
purpose. In fact, using cat could be actively harmful.
--Andy
next prev parent reply other threads:[~2015-03-10 15:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F54AEECA5E2B9541821D670476DAE19C2B8AC95C@PGSMSX102.gar.corp.intel.com>
2015-02-24 12:49 ` Re: [PATCH v2 3/3] efi: Capsule update with user helper interface Kweh, Hock Leong
2015-02-25 11:47 ` Borislav Petkov
2015-02-25 12:38 ` Kweh, Hock Leong
2015-02-25 12:49 ` Borislav Petkov
2015-02-26 15:30 ` Andy Lutomirski
2015-02-26 15:54 ` Borislav Petkov
2015-03-02 11:24 ` Matt Fleming
2015-03-06 21:39 ` Peter Jones
2015-03-06 21:49 ` Roy Franz
2015-03-06 22:17 ` Peter Jones
2015-03-10 12:26 ` Matt Fleming
2015-03-10 15:21 ` Peter Jones
2015-03-10 15:26 ` Andy Lutomirski
2015-03-10 15:40 ` Peter Jones
2015-03-10 15:51 ` Andy Lutomirski [this message]
2015-03-10 17:26 ` Peter Jones
2015-03-10 17:31 ` Andy Lutomirski
2015-03-12 22:47 ` Matt Fleming
2015-03-13 14:42 ` Greg Kroah-Hartman
2015-03-16 15:35 ` Andy Lutomirski
2015-03-02 10:59 Kweh, Hock Leong
2015-03-02 12:29 ` Matt Fleming
2015-03-03 5:56 ` Kweh, Hock Leong
2015-03-03 20:37 ` Andy Lutomirski
2015-03-03 20:49 ` Borislav Petkov
2015-03-03 21:56 ` Andy Lutomirski
2015-03-05 9:18 ` Kweh, Hock Leong
2015-03-05 23:08 ` Andy Lutomirski
2015-03-06 8:13 ` Borislav Petkov
2015-03-06 11:41 ` Kweh, Hock Leong
2015-03-06 14:47 ` Borislav Petkov
2015-03-06 12:20 ` Kweh, Hock Leong
2015-03-06 19:05 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALCETrUDuTt_BK1JSFU=_EEujpm1ekzmkte-c3vxuRW7hWPUPQ@mail.gmail.com' \
--to=luto@amacapital.net \
--cc=boon.leong.ong@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hock.leong.kweh@intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=ming.lei@canonical.com \
--cc=pjones@redhat.com \
--cc=semen.protsenko@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).