From: Andy Lutomirski <luto@amacapital.net>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
Oleg Nesterov <oleg@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Alexei Starovoitov <ast@plumgrid.com>,
Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
X86 ML <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/asm/entry/64: better check for canonical address
Date: Tue, 21 Apr 2015 11:08:42 -0700 [thread overview]
Message-ID: <CALCETrUf3GeNZ8DajRyhJSttpoCoNFV_VHHbNPqJsMArgJdGGg@mail.gmail.com> (raw)
In-Reply-To: <1429633649-20169-1-git-send-email-dvlasenk@redhat.com>
On Tue, Apr 21, 2015 at 9:27 AM, Denys Vlasenko <dvlasenk@redhat.com> wrote:
> This change makes the check exact (no more false positives
> on "negative" addresses).
Acked-by: Andy Lutomirski <luto@kernel.org>
I'll take a full implementation of what Intel says over probably
unmeasurable performance. If anyone in the AMD camp really cared, we
could add X86_BUG_SYSRET_NEEDS_CANONICAL_RCX and use alternatives to
patch this out on AMD. I doubt this would buy us much.
--Andy
next prev parent reply other threads:[~2015-04-21 18:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 16:27 [PATCH] x86/asm/entry/64: better check for canonical address Denys Vlasenko
2015-04-21 18:08 ` Andy Lutomirski [this message]
2015-04-23 15:10 ` Borislav Petkov
2015-04-23 15:41 ` Andy Lutomirski
2015-04-23 15:49 ` Borislav Petkov
2015-04-23 15:52 ` Andy Lutomirski
2015-04-22 14:11 ` [tip:x86/asm] x86/asm/entry/64: Implement better check for canonical addresses tip-bot for Denys Vlasenko
-- strict thread matches above, loose matches on Subject: below --
2015-03-26 12:42 [PATCH] x86/asm/entry/64: better check for canonical address Denys Vlasenko
2015-03-26 18:45 ` Andy Lutomirski
2015-03-27 8:57 ` Borislav Petkov
2015-03-30 14:27 ` Denys Vlasenko
2015-03-30 14:30 ` Andy Lutomirski
2015-03-30 14:45 ` Andy Lutomirski
2015-03-27 8:11 ` Ingo Molnar
2015-03-27 10:45 ` Denys Vlasenko
2015-03-27 11:17 ` Ingo Molnar
2015-03-27 11:28 ` Brian Gerst
2015-03-27 11:34 ` Ingo Molnar
2015-03-27 12:14 ` Denys Vlasenko
2015-03-27 12:16 ` Ingo Molnar
2015-03-27 12:31 ` Denys Vlasenko
2015-03-28 9:11 ` Ingo Molnar
2015-03-29 19:36 ` Denys Vlasenko
2015-03-29 21:12 ` Andy Lutomirski
2015-03-29 21:46 ` Denys Vlasenko
2015-03-31 16:43 ` Ingo Molnar
2015-03-31 17:08 ` Andy Lutomirski
2015-03-31 17:31 ` Denys Vlasenko
2015-03-27 11:27 ` Brian Gerst
2015-03-27 11:31 ` Ingo Molnar
2015-03-27 21:37 ` Andy Lutomirski
2015-04-02 17:37 ` Denys Vlasenko
2015-04-02 18:10 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrUf3GeNZ8DajRyhJSttpoCoNFV_VHHbNPqJsMArgJdGGg@mail.gmail.com \
--to=luto@amacapital.net \
--cc=ast@plumgrid.com \
--cc=bp@alien8.de \
--cc=dvlasenk@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=wad@chromium.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).