From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752834AbcBLS7c (ORCPT ); Fri, 12 Feb 2016 13:59:32 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:35955 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751831AbcBLS7b (ORCPT ); Fri, 12 Feb 2016 13:59:31 -0500 MIME-Version: 1.0 In-Reply-To: <20160202170029.GA1779@malice.jf.intel.com> References: <0e75e48f9944d14ed914342a4780c199095ad747.1453247603.git.luto@kernel.org> <20160122101222.3a29841d@endymion.delvare> <20160130180517.GB1862@malice.jf.intel.com> <20160130201850.3fd167e9@endymion.delvare> <20160202170029.GA1779@malice.jf.intel.com> From: Andy Lutomirski Date: Fri, 12 Feb 2016 10:59:10 -0800 Message-ID: Subject: Re: [PATCH v3] dmi: Make dmi_walk and dmi_walk_early return real error codes To: Darren Hart Cc: Jean Delvare , Andy Lutomirski , =?UTF-8?Q?Pali_Roh=C3=A1r?= , platform-driver-x86@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 2, 2016 at 9:00 AM, Darren Hart wrote: > On Sat, Jan 30, 2016 at 08:18:50PM +0100, Jean Delvare wrote: >> On Sat, 30 Jan 2016 10:13:09 -0800, Andy Lutomirski wrote: >> > On Sat, Jan 30, 2016 at 10:05 AM, Darren Hart wrote: >> > > If I understand this correctly, this is the first of 5 patches, and this one has >> > > some unanswered questions from Jean here. If this patch gets respun, the >> > > following are also impacted: >> > > >> > > dell-wmi: Stop storing pointers to DMI tables >> > > dell-wmi, dell-laptop: select DMI >> > > dell-wmi: Clean up hotkey table size check >> > > dell-wmi: Support new hotkeys on the XPS 13 9350 (Skylake) >> > > >> > > Is that correct? >> > >> > Not really. It's just the three patches here: >> > >> > http://article.gmane.org/gmane.linux.drivers.platform.x86.devel/8503 >> > >> > This patch (the dmi_walk error code one) is no longer really related. >> > Due to Jean's earlier comment about what happens if DMI isn't enabled >> > at all, I no longer propagate the error code from dmi_walk in >> > dell-wmi, so the error code won't have any effect. (Instead I just >> > warn and let the driver load in legacy mode, which matches the current >> > behavior.) >> > >> > I think the way to go is for the v3 "dell-wmi: DMI misuse fixes" >> > series to go in through your tree, and I'll hash out the error code >> > thing separately with Jean. >> > >> > Does that seem sensible? >> >> Yes, I agree that this patch is independent from the dell-wmi patch >> series now. > > Excellent, works for me. > Is any further action from me needed here? --Andy