From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753651AbdLMRCN (ORCPT <rfc822;w@1wt.eu>);
        Wed, 13 Dec 2017 12:02:13 -0500
Received: from mail.kernel.org ([198.145.29.99]:58976 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753301AbdLMRCM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 13 Dec 2017 12:02:12 -0500
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 842FB218D8
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=luto@kernel.org
X-Google-Smtp-Source: ACJfBou+b/AoqM6adH/7EyOljismZF24FlxJ5b9hKa+VWEK8Zak7nlUAgNuOYmqPMEPNQgPNtgybrnVyy5RoXq7rfSY=
MIME-Version: 1.0
In-Reply-To: <20171213131205.adxjdggby7qpv22q@node.shutemov.name>
References: <cover.1513035461.git.luto@kernel.org> <5eafbf867b587032f322898953d550d5bcaf751b.1513035461.git.luto@kernel.org>
 <20171213131205.adxjdggby7qpv22q@node.shutemov.name>
From: Andy Lutomirski <luto@kernel.org>
Date: Wed, 13 Dec 2017 09:01:50 -0800
X-Gmail-Original-Message-ID: <CALCETrV-w-v8bNTE6q5EZwxm=H3HvwY+SDW3jJ3x5DFq3NzkfA@mail.gmail.com>
Message-ID: <CALCETrV-w-v8bNTE6q5EZwxm=H3HvwY+SDW3jJ3x5DFq3NzkfA@mail.gmail.com>
Subject: Re: [PATCH PTI v3 03/10] x86/pti/64: Fix ESPFIX64 user mapping
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Borislav Petkov <bp@alien8.de>, Brian Gerst <brgerst@gmail.com>,
        David Laight <David.Laight@aculab.com>,
        Kees Cook <keescook@chromium.org>,
        Peter Zijlstra <peterz@infradead.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 13, 2017 at 5:12 AM, Kirill A. Shutemov
<kirill@shutemov.name> wrote:
> On Tue, Dec 12, 2017 at 07:56:38AM -0800, Andy Lutomirski wrote:
>> The ESPFIX64 user mapping belongs in pti.c just like all the other
>> user mappings.  Move it there and make it work correctly while we're
>> at it.
>>
>> Signed-off-by: Andy Lutomirski <luto@kernel.org>
>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
>
> BTW, why do we open-code p?d_alloc() in pti_user_pagetable_walk_*()?
> It seems unnecessary and potentially bogus: see smp_wmb() in __p?d_alloc()
> helpers.

The helpers won't work -- we're allocating kernel-owned tables in the
usermode part of init_mm.  The p?d_alloc() helpers allocate
user-accounted tables in the kernelmode part of the mm.

--Andy