From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932671AbcINSWX (ORCPT <rfc822;w@1wt.eu>);
        Wed, 14 Sep 2016 14:22:23 -0400
Received: from mail-yw0-f174.google.com ([209.85.161.174]:35439 "EHLO
        mail-yw0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752151AbcINSWV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 14 Sep 2016 14:22:21 -0400
MIME-Version: 1.0
In-Reply-To: <20160914145556.5whqcpzys7c23nib@treble>
References: <cover.1473801993.git.luto@kernel.org> <7cd5e328dc75d8ccd912e5783665de34503f7c63.1473801993.git.luto@kernel.org>
 <20160914145556.5whqcpzys7c23nib@treble>
From: Andy Lutomirski <luto@amacapital.net>
Date: Wed, 14 Sep 2016 11:22:00 -0700
Message-ID: <CALCETrV9nF2cgmutieikg99diaEvkB6yub0p5M2Cei6wKD1YOA@mail.gmail.com>
Subject: Re: [PATCH 08/12] x86/dumpstack: Pin the target stack in save_stack_trace_tsk()
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Brian Gerst <brgerst@gmail.com>, Jann Horn <jann@thejh.net>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 14, 2016 at 7:55 AM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> On Tue, Sep 13, 2016 at 02:29:28PM -0700, Andy Lutomirski wrote:
>> This will prevent a crash if the target task dies before or while
>> dumping its stack once we start freeing task stacks early.
>>
>> Signed-off-by: Andy Lutomirski <luto@kernel.org>
>
> Do we need a similar patch for show_stack()?

Probably.  Shouldn't it go in show_stack_log_lvl() instead, though?