From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753224AbdKNCOA (ORCPT ); Mon, 13 Nov 2017 21:14:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:55782 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbdKNCN7 (ORCPT ); Mon, 13 Nov 2017 21:13:59 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5D8D21904 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=luto@kernel.org X-Google-Smtp-Source: AGs4zMaQkDMf1K17Sfpe9SR24SqRgh3LXjOuMMADPfKg6kuQn/qJfX7eq4Vm8F/ljezWmVqfzrEfAHWxTvdBempABb0= MIME-Version: 1.0 In-Reply-To: <20171113224651.kjeh5wbb2xadf6xb@treble> References: <20171113224651.kjeh5wbb2xadf6xb@treble> From: Andy Lutomirski Date: Mon, 13 Nov 2017 18:13:37 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 7/7] x86/unwind/64: Add support for the SYSENTER stack To: Josh Poimboeuf Cc: Andy Lutomirski , X86 ML , Borislav Petkov , "linux-kernel@vger.kernel.org" , Brian Gerst , Dave Hansen , Linus Torvalds Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 13, 2017 at 2:46 PM, Josh Poimboeuf wrote: > On Fri, Nov 10, 2017 at 08:05:26PM -0800, Andy Lutomirski wrote: >> Signed-off-by: Andy Lutomirski > > I would make the subject more specific and less unwinder-centric, like: > > "x86/dumpstack: Add get_stack_info() support for the SYSENTER stack" > > since there aren't yet any changes to the unwinders themselves (which > I'm assuming will be needed once you start using the stack). > > Also, at least a one-sentence description would be good. > > Otherwise the patch looks good to me. Done. I also added 32-bit support. > > -- > Josh