From: Andy Lutomirski <luto@amacapital.net>
To: Serge Hallyn <serge.hallyn@ubuntu.com>
Cc: gnome-os-list@gnome.org,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
mclasen@redhat.com,
Linux Containers <containers@lists.linux-foundation.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] devpts: Make ptmx be owned by the userns owner instead of userns-local 0
Date: Tue, 15 Mar 2016 11:21:23 -0700 [thread overview]
Message-ID: <CALCETrVe+2mb9xEPO_Vk8poX=dR2qp4OM=23JOspSibKZK3GSg@mail.gmail.com> (raw)
In-Reply-To: <20160314083501.GB23225@ubuntumail>
On Mar 14, 2016 1:35 AM, "Serge Hallyn" <serge.hallyn@ubuntu.com> wrote:
>
> Quoting Andy Lutomirski (luto@kernel.org):
> > We used to have ptmx be owned by the inner uid and gid 0. Change
> > this: if the owner and group are both mapped but are not both 0,
> > then use the owner instead.
> >
> > For container-style namespaces (LXC, etc), this should have no
> > effect -- UID 0 is will either be the owner or will be unmapped.
>
> This doesn't seem right - it's often the case that the owner is mapped
> in as non-0 uid, safe or not. The actual namespace root uid should be
> the owner (so long as it exists).
>
> Why not reverse the cases? If 0 is not mapped, then check whether the
> current_user_ns()->owner is mapped?
Good point, and less chance of breakage that way as well.
--Andy
next prev parent reply other threads:[~2016-03-15 18:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 5:06 [PATCH] devpts: Make ptmx be owned by the userns owner instead of userns-local 0 Andy Lutomirski
2016-03-14 8:35 ` Serge Hallyn
2016-03-15 18:21 ` Andy Lutomirski [this message]
2016-03-14 15:42 ` Alexander Larsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALCETrVe+2mb9xEPO_Vk8poX=dR2qp4OM=23JOspSibKZK3GSg@mail.gmail.com' \
--to=luto@amacapital.net \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gnome-os-list@gnome.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mclasen@redhat.com \
--cc=serge.hallyn@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).