From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752343AbcIOSFR (ORCPT ); Thu, 15 Sep 2016 14:05:17 -0400 Received: from mail-yw0-f172.google.com ([209.85.161.172]:33532 "EHLO mail-yw0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751085AbcIOSFI (ORCPT ); Thu, 15 Sep 2016 14:05:08 -0400 MIME-Version: 1.0 In-Reply-To: <20160914183501.cknjhsbkzxg6m6pl@treble> References: <7cd5e328dc75d8ccd912e5783665de34503f7c63.1473801993.git.luto@kernel.org> <20160914145556.5whqcpzys7c23nib@treble> <20160914183501.cknjhsbkzxg6m6pl@treble> From: Andy Lutomirski Date: Thu, 15 Sep 2016 11:04:47 -0700 Message-ID: Subject: Re: [PATCH 08/12] x86/dumpstack: Pin the target stack in save_stack_trace_tsk() To: Josh Poimboeuf Cc: Andy Lutomirski , X86 ML , Borislav Petkov , "linux-kernel@vger.kernel.org" , Brian Gerst , Jann Horn Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 14, 2016 at 11:35 AM, Josh Poimboeuf wrote: > On Wed, Sep 14, 2016 at 11:22:00AM -0700, Andy Lutomirski wrote: >> On Wed, Sep 14, 2016 at 7:55 AM, Josh Poimboeuf wrote: >> > On Tue, Sep 13, 2016 at 02:29:28PM -0700, Andy Lutomirski wrote: >> >> This will prevent a crash if the target task dies before or while >> >> dumping its stack once we start freeing task stacks early. >> >> >> >> Signed-off-by: Andy Lutomirski >> > >> > Do we need a similar patch for show_stack()? >> >> Probably. Shouldn't it go in show_stack_log_lvl() instead, though? > > Yeah, that would probably be better. This code is a colossal mess. I really hope that, some day, we can clarify which entry points are used only in dumpstack*.c and which are used elsewhere. Creating an arch/x86/kernel/dumpstack.h or just merging the three files and removing all the intermediate crap from the headers could help a lot.