From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754562AbbCIPSw (ORCPT <rfc822;w@1wt.eu>);
	Mon, 9 Mar 2015 11:18:52 -0400
Received: from mail-la0-f48.google.com ([209.85.215.48]:45431 "EHLO
	mail-la0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753398AbbCIPSu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 9 Mar 2015 11:18:50 -0400
MIME-Version: 1.0
In-Reply-To: <20150309151355.GA21109@gmail.com>
References: <1425909943-14687-1-git-send-email-dvlasenk@redhat.com>
 <CALCETrV0zvMjZcd=Ctvxxr_1Zr37HUnbAyddpTuzBuKOWeP8Tw@mail.gmail.com>
 <CAK1hOcOtCuuFJoCmR_T=K9=g-i0cqmu4QYoQJ6C2Utg6wbNf4A@mail.gmail.com> <20150309151355.GA21109@gmail.com>
From: Andy Lutomirski <luto@amacapital.net>
Date: Mon, 9 Mar 2015 08:18:28 -0700
Message-ID: <CALCETrVydzWCQ03=UDb4paT6y8_YULn08pgoYng8-oHF4ZAv7w@mail.gmail.com>
Subject: Re: [PATCH] x86: entry_32.S: change ESPFIX test to not touch PT_OLDSS(%esp)
To: Ingo Molnar <mingo@kernel.org>
Cc: Denys Vlasenko <vda.linux@googlemail.com>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Steven Rostedt <rostedt@goodmis.org>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        Kees Cook <keescook@chromium.org>, X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Mar 9, 2015 at 8:13 AM, Ingo Molnar <mingo@kernel.org> wrote:
>
> * Denys Vlasenko <vda.linux@googlemail.com> wrote:
>
>> > That being said, what ends up in the high bits of esp when we iret
>> > to vm86 mode?
>>
>> I don't know. I guess it's time to write an actual vm86 testcase :)
>
> Btw., could you please stick it and your other testcases into
> tools/x86/tests/ or so? Having such a testsuite would ease maintenance
> considerably.
>

My excuse used to be that the test actively exploited really nasty
security issues.  Then it was that I was waiting for the
infrastructure to stabilize a bit.  I'll go see how it's looking now.

--Andy

> Thanks,
>
>         Ingo



-- 
Andy Lutomirski
AMA Capital Management, LLC