From: Andy Lutomirski <luto@amacapital.net>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Andy Lutomirski <luto@kernel.org>, Ingo Molnar <mingo@kernel.org>,
X86 ML <x86@kernel.org>, Shuah Khan <shuah.kh@samsung.com>,
Borislav Petkov <bp@alien8.de>,
Denys Vlasenko <vda.linux@googlemail.com>,
Steven Rostedt <rostedt@goodmis.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] x86, selftests: Add sigreturn selftest
Date: Tue, 7 Apr 2015 21:39:54 -0700 [thread overview]
Message-ID: <CALCETrW+UfcXnxHq_8mHGQBGKY_86XeT1PhErVVRZcTtF655SA@mail.gmail.com> (raw)
In-Reply-To: <1428464530.29968.3.camel@ellerman.id.au>
On Tue, Apr 7, 2015 at 8:42 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
> On Mon, 2015-04-06 at 23:11 -0700, Andy Lutomirski wrote:
>> On Mon, Apr 6, 2015 at 8:39 PM, Michael Ellerman <mpe@ellerman.id.au> wrote:
>> > On Mon, 2015-04-06 at 19:01 -0700, Andy Lutomirski wrote:
>> >> This is my sigreturn test, added mostly unchanged from its old home.
>> >> It exercises the sigreturn(2) syscall, specifically focusing on its
>> >> interactions with various IRET corner cases. It tests for correct
>> >> behavior in several areas that were historically dangerously buggy.
>> >> For example, it exercises espfix on kernels of both bitnesses under
>> >> various conditions, and it contains exploits for several now-fixed
>> >> bugs in IRET error handling.
>> >>
>> >> If you run it on older kernels, your system will crash. It probably
>> >> won't eat your data in the process.
>> >>
>> >> There is no released kernel on which the sigreturn_64 test will
>> >> pass, but it passes on tip:x86/asm.
>> >>
>> >> IMO it's unfortunate that I need to provide a special script to run
>> >> tests. I'd rather just list my targets.
>> >
>> > If you use lib.mk you can.
>> >
>> > https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git/log/?h=next
>> >
>> > See for example:
>> >
>> > https://git.kernel.org/cgit/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=next&id=5744de542dd4b963c2975e6f70844ce2899864e4
>>
>> Will do for 4.2. In the mean time, there's no base on which lib.mk
>> exists and the test works.
>
> OK.
>
> Shua seems to have already sent a pull request for 4.1, which is rather early
> to say the least, but suggests you've missed 4.1 anyway - unless you want it to
> go via some other tree.
The plan is to go in via tip:x86/asm, I think. That's where the fix
that the test depends on lives.
--Andy
prev parent reply other threads:[~2015-04-08 4:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 2:01 [PATCH v4] x86, selftests: Add sigreturn selftest Andy Lutomirski
2015-04-07 3:39 ` Michael Ellerman
2015-04-07 6:11 ` Andy Lutomirski
2015-04-08 3:42 ` Michael Ellerman
2015-04-08 4:39 ` Andy Lutomirski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrW+UfcXnxHq_8mHGQBGKY_86XeT1PhErVVRZcTtF655SA@mail.gmail.com \
--to=luto@amacapital.net \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=rostedt@goodmis.org \
--cc=shuah.kh@samsung.com \
--cc=vda.linux@googlemail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).