linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@amacapital.net>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: linux-nvdimm <linux-nvdimm@ml01.01.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Borislav Petkov <bp@alien8.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Robert <elliott@hpe.com>, Ingo Molnar <mingo@kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	X86 ML <x86@kernel.org>
Subject: Re: [PATCH v8 3/3] x86, mce: Add __mcsafe_copy()
Date: Mon, 11 Jan 2016 16:37:35 -0800	[thread overview]
Message-ID: <CALCETrW3pFjSedmKRdV+a3-_OwgcBLHqfZYesC=pO3-0T3JK4A@mail.gmail.com> (raw)
In-Reply-To: <20160112002645.GA10179@agluck-desk.sc.intel.com>

On Mon, Jan 11, 2016 at 4:26 PM, Luck, Tony <tony.luck@intel.com> wrote:
> On Fri, Jan 08, 2016 at 05:49:30PM -0800, Andy Lutomirski wrote:
>> Also, what's the sfence for?  You don't seem to be using any
>> non-temporal operations.
>
> So I deleted the "sfence" and now I just have a comment
> at the 100: label.
>
> 37:
>         shl $6,%ecx
>         lea -48(%ecx,%edx),%edx
>         jmp 100f
> 38:
>         shl $6,%ecx
>         lea -56(%ecx,%edx),%edx
>         jmp 100f
> 39:
>         lea (%rdx,%rcx,8),%rdx
>         jmp 100f
> 40:
>         mov %ecx,%edx
> 100:
>         /* %rax set the fault number in fixup_exception() */
>         ret
>
> Should I just change all the "jmp 100f" into "ret"?  There
> aren't any tools that will be confused that the function
> has 10 returns, are there?
>

Given that gcc does that too, it should be fine.

--Andy\

      parent reply	other threads:[~2016-01-12  0:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-09  0:04 [PATCH v8 0/3] Machine check recovery when kernel accesses poison Tony Luck
2015-12-31 19:40 ` [PATCH v8 2/3] x86, mce: Check for faults tagged in EXTABLE_CLASS_FAULT exception table entries Tony Luck
2016-01-08 20:49 ` [PATCH v8 1/3] x86: Expand exception table to allow new handling options Tony Luck
2016-01-09  1:52   ` Andy Lutomirski
2016-01-09  3:39     ` Brian Gerst
2016-01-09  4:31       ` Brian Gerst
2016-01-09  6:36         ` Andy Lutomirski
2016-01-11 23:09           ` Brian Gerst
2016-01-11 23:22             ` Andy Lutomirski
2016-01-11 23:48             ` Luck, Tony
2016-01-09 17:45     ` Tony Luck
2016-01-09 18:00       ` Andy Lutomirski
2016-01-09 19:51         ` Tony Luck
2016-01-09 22:32           ` Andy Lutomirski
2016-01-10  1:15             ` Tony Luck
2016-01-11  0:25     ` Luck, Tony
2016-01-08 21:18 ` [PATCH v8 3/3] x86, mce: Add __mcsafe_copy() Tony Luck
2016-01-09  1:49   ` Andy Lutomirski
2016-01-09 17:48     ` Tony Luck
2016-01-09 17:57       ` Andy Lutomirski
2016-01-09 19:39         ` Tony Luck
2016-01-09 22:15           ` Dan Williams
2016-01-09 22:33             ` Andy Lutomirski
2016-01-10  0:23               ` Dan Williams
2016-01-10  1:40                 ` Tony Luck
2016-01-10 11:26                   ` Borislav Petkov
2016-01-11 10:44                     ` Ingo Molnar
2016-01-13 23:22                       ` Tony Luck
2016-01-14  4:39                         ` Borislav Petkov
2016-01-30  0:35                           ` Tony Luck
2016-01-30 10:28                             ` Borislav Petkov
2016-02-01 23:10                               ` Tony Luck
2016-02-01 23:16                                 ` Dan Williams
2016-01-12  0:26     ` Luck, Tony
2016-01-12  0:30       ` Andy Lutomirski
2016-01-12  0:37       ` Andy Lutomirski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALCETrW3pFjSedmKRdV+a3-_OwgcBLHqfZYesC=pO3-0T3JK4A@mail.gmail.com' \
    --to=luto@amacapital.net \
    --cc=akpm@linux-foundation.org \
    --cc=bp@alien8.de \
    --cc=dan.j.williams@intel.com \
    --cc=elliott@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nvdimm@ml01.01.org \
    --cc=mingo@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).