From: Andy Lutomirski <luto@amacapital.net>
To: Dmitry Safonov <dsafonov@virtuozzo.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Andy Lutomirski <luto@kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
X86 ML <x86@kernel.org>
Subject: Re: [PATCH 2/2] x86/vdso: set vdso pointer only after success
Date: Thu, 27 Oct 2016 15:25:53 -0700 [thread overview]
Message-ID: <CALCETrW=qxgd3UpimGFCjHLVb1sgRjqOE1KNps=CT4cmVo7B_w@mail.gmail.com> (raw)
In-Reply-To: <20161027141516.28447-3-dsafonov@virtuozzo.com>
On Thu, Oct 27, 2016 at 7:15 AM, Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
> Those pointers were initialized before call to _install_special_mapping
> after the commit f7b6eb3fa072 ("x86: Set context.vdso before installing
> the mapping"). This is not required anymore as special mappings have
> their vma name and don't use arch_vma_name() after commit a62c34bd2a8a
> ("x86, mm: Improve _install_special_mapping and fix x86 vdso naming").
> So, this way to init looks less entangled.
> I even belive, we can remove null initializers:
> - on failure load_elf_binary() will not start a new thread;
> - arch_prctl will have the same pointers as before syscall.
Acked-by: Andy Lutomirski <luto@kernel.org>
next prev parent reply other threads:[~2016-10-27 22:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 14:15 [PATCH 0/2] x86/vdso: small fixups for map_vdso Dmitry Safonov
2016-10-27 14:15 ` [PATCH 1/2] x86/prctl/uapi: remove ifdef for CHECKPOINT_RESTORE Dmitry Safonov
2016-10-28 6:48 ` [tip:x86/asm] x86/prctl/uapi: Remove #ifdef " tip-bot for Dmitry Safonov
2016-10-27 14:15 ` [PATCH 2/2] x86/vdso: set vdso pointer only after success Dmitry Safonov
2016-10-27 22:25 ` Andy Lutomirski [this message]
2016-10-28 6:49 ` [tip:x86/asm] x86/vdso: Set vDSO " tip-bot for Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALCETrW=qxgd3UpimGFCjHLVb1sgRjqOE1KNps=CT4cmVo7B_w@mail.gmail.com' \
--to=luto@amacapital.net \
--cc=0x7f454c46@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dsafonov@virtuozzo.com \
--cc=gorcunov@openvz.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).