From: Andy Lutomirski <email@example.com> To: Andy Lutomirski <firstname.lastname@example.org> Cc: Jens Axboe <email@example.com>, "firstname.lastname@example.org" <email@example.com>, Kai-Heng Feng <firstname.lastname@example.org>, linux-nvme <email@example.com>, Christoph Hellwig <firstname.lastname@example.org>, Sagi Grimberg <email@example.com>, Keith Busch <firstname.lastname@example.org> Subject: Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11 Date: Wed, 19 Apr 2017 21:52:17 -0700 [thread overview] Message-ID: <CALCETrWCQh1dOkqn_g6QVXpLR8U7BjnfOtsSPZ+DCxK5hf_sHw@mail.gmail.com> (raw) In-Reply-To: <CALCETrWY_Wc0n24hfwj53aH-gc4xeRCuU+=O78dui9Mm7k0jEw@mail.gmail.com> On Wed, Apr 19, 2017 at 8:55 PM, Andy Lutomirski <email@example.com> wrote: > On Wed, Apr 19, 2017 at 8:10 PM, Jens Axboe <firstname.lastname@example.org> wrote: >> On Wed, Apr 19 2017, Andy Lutomirski wrote: >>> Sorry for waiting so long for this. I was waiting for feedback from >>> Samsung, but they haven't root-caused the issue yet, and I should >>> have just done this from the beginning. >>> >>> This series makes APST more debuggable and updates the quirk list. >>> The quirks I'm aware of are: >>> >>> - Samsung 950 series SSDs in Dell XPS 15 9550 and Precision 5510 >>> laptops (which are essentially the same laptop) can lose their >>> PCIe link if they're allowed to use the deepest APST state. >>> Samsung engineers have an affected system and are working on >>> it. The same exact SSDs in other machines (even an XPS 13) >>> seem to work fine. >>> >>> - One Toshiba device malfunctions if APST is used at all. >> >> You need to split this series in two, patches 1-3 can wait. For 4.11, >> all we need to do is turn off APST on any device that potentially has >> this problem. >> >>> One thing that improves my confidence that there aren't too many >>> more problems with APST is that Ubuntu has backported APST to Zesty, >>> so it's already gotten a bit of testing in a widely used (if very >>> new) release. >> >> Honestly, I think the best path for 4.11 is to turn off APST by default, >> make it opt-in instead. I don't share your optimism here, as I made >> clear back from before we even merged this feature. >> >> > > I can make it so that force_apst=0 means no APST and force_apst=1 mean > yes APST and we could try again with a quirk list for 4.12. There's a > decent chance that a few more weeks with Ubuntu having APST on will > shake out all the problems fairly quickly. Here's a more concrete and more sensible proposal: For 4.11: force_apst=0: Default. APST off on all Samsung 950-like devices regardless of what laptop and on the Toshiba device. force_apst=1: Use APST except where known bad. APST deepest state disabled on Samsung 950-like devices on XPS 15 and Precision 5510. APST off on the Toshiba device. force_apst=2: APST fully on regardless of any quirks. For 4.12-rc1: force_apst=0 works like force_apst=1, but we keep both values for compatibility and in case we need to add another overly broad quirk some day. Would something like this make sense?
next prev parent reply other threads:[~2017-04-20 4:52 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-20 3:02 Andy Lutomirski 2017-04-20 3:02 ` [PATCH 1/5] nvme: Fix APST comment Andy Lutomirski 2017-04-20 3:02 ` [PATCH 2/5] nvme: Display raw APST configuration via DYNAMIC_DEBUG Andy Lutomirski 2017-04-20 3:02 ` [PATCH 3/5] nvme: Add nvme_core.force_apst to ignore the NO_APST quirk Andy Lutomirski 2017-04-20 3:02 ` [PATCH 4/5] nvme: Adjust the Samsung APST quirk Andy Lutomirski 2017-04-20 3:07 ` Jens Axboe 2017-04-20 3:51 ` Andy Lutomirski [not found] ` <CGME20170420043337uscas1p1614437f255a643cdb08e44c4fd43424f@uscas1p1.samsung.com> 2017-04-20 4:33 ` Judy Brock 2017-04-20 3:02 ` [PATCH 5/5] nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA" Andy Lutomirski 2017-04-20 3:10 ` [PATCH 0/5] nvme APST fixes/improvements for 4.11 Jens Axboe 2017-04-20 3:55 ` Andy Lutomirski 2017-04-20 4:52 ` Andy Lutomirski [this message] 2017-04-20 5:19 ` Christoph Hellwig 2017-04-20 16:01 ` Andy Lutomirski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CALCETrWCQh1dOkqn_g6QVXpLR8U7BjnfOtsSPZ+DCxK5hf_sHw@mail.gmail.com \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --subject='Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).