From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758200AbbCPPel (ORCPT <rfc822;w@1wt.eu>);
	Mon, 16 Mar 2015 11:34:41 -0400
Received: from mail-qc0-f178.google.com ([209.85.216.178]:34645 "EHLO
	mail-qc0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756692AbbCPPeh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 16 Mar 2015 11:34:37 -0400
MIME-Version: 1.0
In-Reply-To: <20150316093537.GC22995@pd.tnic>
References: <20150313145542.GD21603@redhat.com> <20150313161958.GI31998@pd.tnic>
 <20150313162654.GA26453@redhat.com> <20150313192717.GJ31998@pd.tnic>
 <20150314144816.GA13029@redhat.com> <20150315173620.GA29134@pd.tnic>
 <20150315181643.GA488@redhat.com> <20150315185048.GB29134@pd.tnic>
 <20150315200436.GA30079@redhat.com> <20150315203816.GC29134@pd.tnic> <20150316093537.GC22995@pd.tnic>
From: Andy Lutomirski <luto@amacapital.net>
Date: Mon, 16 Mar 2015 08:34:15 -0700
Message-ID: <CALCETrWFwSXVPUDVhYY3Cy05vjznT5_g1+9b+H=fpZFivB2CYg@mail.gmail.com>
Subject: Re: [PATCH 4/4] x86/fpu: don't abuse drop_init_fpu() in flush_thread()
To: Borislav Petkov <bp@suse.de>
Cc: Fenghua Yu <fenghua.yu@intel.com>,
        Quentin Casasnovas <quentin.casasnovas@oracle.com>,
        Suresh Siddha <sbsiddha@gmail.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Dave Hansen <dave.hansen@intel.com>, Oleg Nesterov <oleg@redhat.com>,
        Rik van Riel <riel@redhat.com>, Pekka Riikonen <priikone@iki.fi>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mar 16, 2015 2:37 AM, "Borislav Petkov" <bp@suse.de> wrote:
>
> On Sun, Mar 15, 2015 at 09:38:16PM +0100, Borislav Petkov wrote:
> > How about we call this function fpu_reset_state() instead?
>
> IOW, something like this. Reading the usage sites actually make much
> more sense to me now. It could be just me though...
>
> :-)
>
> ---
> From: Borislav Petkov <bp@suse.de>
> Date: Mon, 16 Mar 2015 10:21:55 +0100
> Subject: [PATCH] x86/fpu: Rename drop_init_fpu() to fpu_reset_state()
>
> Call it what it does and in accordance with the context where it is
> used: we reset the FPU state either because we were unable to restore it
> from the one saved in the task or because we simply want to reset it.

Nice!  This is the first time I've actually understood that :). I
still have no idea what "init" referred to...

--Andy