From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0328C433E2 for ; Tue, 14 Jul 2020 19:27:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BDD57225AB for ; Tue, 14 Jul 2020 19:27:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594754831; bh=P5jNGMBlBX/QkkJRNB1+sQIGoUmYLPb4UbvcuiwyfXU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=VwZWA73xODPjbAPs2AaejeriqLGtRbAEWYEIXKjhkYcanh3A7bdXNuIH0Wy1Xbnze O0GIJYxHcgiB+YzilC+hCy0DXDVfPXt6maLmRj3Gsp5uznhZx1D5FCtSHoNSkXKBh1 6DgO0wlKUbX9mWkLBwVy0vnWj3yeA2eVQEcHJa4o= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729328AbgGNT1K (ORCPT ); Tue, 14 Jul 2020 15:27:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:45602 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728370AbgGNT1J (ORCPT ); Tue, 14 Jul 2020 15:27:09 -0400 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C0EE7225AB for ; Tue, 14 Jul 2020 19:27:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594754829; bh=P5jNGMBlBX/QkkJRNB1+sQIGoUmYLPb4UbvcuiwyfXU=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=D7ZxWEJC3oQ/TI0IJ+5dDrybFphlb1csCiK3XkuOwP5oqHfRRzbdSKZ8IeBpUScMP lCa2ypQlxbT2mEOffrh1BYDi8jYiyr0Ljl/I5PCQDiJITjiRfyH95Z52Rh+lMuxFk1 vJFM3kQtm5MzPWXR3+A81e5kYbG75dRPjlYXeOLA= Received: by mail-wm1-f47.google.com with SMTP id q15so8337733wmj.2 for ; Tue, 14 Jul 2020 12:27:08 -0700 (PDT) X-Gm-Message-State: AOAM530Ed+yF41a94NnNzQyNioQ5Moth81TTryB0W5q+RBbH/ngmil79 L1JZCaYehCMmKDGJIYBHO+DSL2KgwBZjsZdFMprYLw== X-Google-Smtp-Source: ABdhPJxdA00P6WYL5aBprrtpWULRdP3PtUO6mZJTS1tjNWVBTfJxhDStj7KTroekfThk3dz/LDqSAqwPthtxEIwVRio= X-Received: by 2002:a7b:c92e:: with SMTP id h14mr4877690wml.36.1594748492474; Tue, 14 Jul 2020 10:41:32 -0700 (PDT) MIME-Version: 1.0 References: <20200616142315.375918-1-brgerst@gmail.com> <20200714064004.GA32655@lst.de> In-Reply-To: From: Andy Lutomirski Date: Tue, 14 Jul 2020 10:41:18 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] X32 syscall cleanups To: Brian Gerst Cc: Christoph Hellwig , Linux Kernel Mailing List , "the arch/x86 maintainers" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Andy Lutomirski , Arnd Bergmann Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 14, 2020 at 10:03 AM Brian Gerst wrote:> > On Tue, Jul 14, 2020 at 2:40 AM Christoph Hellwig wrote: > > > > On Tue, Jun 16, 2020 at 10:23:13AM -0400, Brian Gerst wrote: > > > Christoph Hellwig uncovered an issue with how we currently handle X32 > > > syscalls. Currently, we can only use COMPAT_SYS_DEFINEx() for X32 > > > specific syscalls. These changes remove that restriction and allow > > > native syscalls. > > > > Did this go anywhere? > > This approach wasn't well received, so I'd just go with this as the > simplest solution: > https://lore.kernel.org/lkml/CAK8P3a17h782gO65qJ9Mmz0EuiTSKQPEyr_=nvqOtnmQZuh9Kw@mail.gmail.com/ > I'm okay with either approach, although I think the original approach is nicer than the simplified #define approach. In my mind, the __x64_omg_so_many_underscores prefixes really mean "don't think too hard about these -- we just decided to make extra long names", so whatever. We can clean it up more some day. > -- > Brian Gerst