From: Andy Lutomirski <firstname.lastname@example.org> To: Jens Axboe <email@example.com> Cc: Andy Lutomirski <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, Kai-Heng Feng <email@example.com>, linux-nvme <firstname.lastname@example.org>, Christoph Hellwig <email@example.com>, Sagi Grimberg <firstname.lastname@example.org>, Keith Busch <email@example.com> Subject: Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11 Date: Wed, 19 Apr 2017 20:55:47 -0700 [thread overview] Message-ID: <CALCETrWY_Wc0n24hfwj53aH-gc4xeRCuU+=O78dui9Mm7k0jEw@mail.gmail.com> (raw) In-Reply-To: <20170420030959.GC23085@kernel.dk> On Wed, Apr 19, 2017 at 8:10 PM, Jens Axboe <firstname.lastname@example.org> wrote: > On Wed, Apr 19 2017, Andy Lutomirski wrote: >> Sorry for waiting so long for this. I was waiting for feedback from >> Samsung, but they haven't root-caused the issue yet, and I should >> have just done this from the beginning. >> >> This series makes APST more debuggable and updates the quirk list. >> The quirks I'm aware of are: >> >> - Samsung 950 series SSDs in Dell XPS 15 9550 and Precision 5510 >> laptops (which are essentially the same laptop) can lose their >> PCIe link if they're allowed to use the deepest APST state. >> Samsung engineers have an affected system and are working on >> it. The same exact SSDs in other machines (even an XPS 13) >> seem to work fine. >> >> - One Toshiba device malfunctions if APST is used at all. > > You need to split this series in two, patches 1-3 can wait. For 4.11, > all we need to do is turn off APST on any device that potentially has > this problem. > >> One thing that improves my confidence that there aren't too many >> more problems with APST is that Ubuntu has backported APST to Zesty, >> so it's already gotten a bit of testing in a widely used (if very >> new) release. > > Honestly, I think the best path for 4.11 is to turn off APST by default, > make it opt-in instead. I don't share your optimism here, as I made > clear back from before we even merged this feature. > > I can make it so that force_apst=0 means no APST and force_apst=1 mean yes APST and we could try again with a quirk list for 4.12. There's a decent chance that a few more weeks with Ubuntu having APST on will shake out all the problems fairly quickly. --Andy
next prev parent reply other threads:[~2017-04-20 3:56 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-20 3:02 Andy Lutomirski 2017-04-20 3:02 ` [PATCH 1/5] nvme: Fix APST comment Andy Lutomirski 2017-04-20 3:02 ` [PATCH 2/5] nvme: Display raw APST configuration via DYNAMIC_DEBUG Andy Lutomirski 2017-04-20 3:02 ` [PATCH 3/5] nvme: Add nvme_core.force_apst to ignore the NO_APST quirk Andy Lutomirski 2017-04-20 3:02 ` [PATCH 4/5] nvme: Adjust the Samsung APST quirk Andy Lutomirski 2017-04-20 3:07 ` Jens Axboe 2017-04-20 3:51 ` Andy Lutomirski [not found] ` <CGME20170420043337uscas1p1614437f255a643cdb08e44c4fd43424f@uscas1p1.samsung.com> 2017-04-20 4:33 ` Judy Brock 2017-04-20 3:02 ` [PATCH 5/5] nvme: Quirk APST off on "THNSF5256GPUK TOSHIBA" Andy Lutomirski 2017-04-20 3:10 ` [PATCH 0/5] nvme APST fixes/improvements for 4.11 Jens Axboe 2017-04-20 3:55 ` Andy Lutomirski [this message] 2017-04-20 4:52 ` Andy Lutomirski 2017-04-20 5:19 ` Christoph Hellwig 2017-04-20 16:01 ` Andy Lutomirski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CALCETrWY_Wc0n24hfwj53aH-gc4xeRCuU+=O78dui9Mm7k0jEw@mail.gmail.com' \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH 0/5] nvme APST fixes/improvements for 4.11' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).