From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752728AbdK3P75 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 30 Nov 2017 10:59:57 -0500
Received: from mail.kernel.org ([198.145.29.99]:40808 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751844AbdK3P74 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2017 10:59:56 -0500
DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 90B1A21912
Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org
Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=luto@kernel.org
X-Google-Smtp-Source: AGs4zMZ8B/CtE/XiPcBkr/Su+5PHtVSRSZ7NETQt1301Oh4hQHRaOC/I3XSjwonS3DYJ8OsKwVxk92S4AShLTjT9fhU=
MIME-Version: 1.0
In-Reply-To: <6b31721ea92f51ea839e79bd97ade4a75b1eeea2.1512057304.git.luto@kernel.org>
References: <6b31721ea92f51ea839e79bd97ade4a75b1eeea2.1512057304.git.luto@kernel.org>
From: Andy Lutomirski <luto@kernel.org>
Date: Thu, 30 Nov 2017 07:59:34 -0800
X-Gmail-Original-Message-ID: <CALCETrWdx7yRcKu3svcrQczjyGy_oXgjc9NcHbf_Bba9psKETw@mail.gmail.com>
Message-ID: <CALCETrWdx7yRcKu3svcrQczjyGy_oXgjc9NcHbf_Bba9psKETw@mail.gmail.com>
Subject: Re: [PATCH] x86/power: Fix some ordering bugs in __restore_processor_context()
To: Andy Lutomirski <luto@kernel.org>
Cc: X86 ML <x86@kernel.org>, Jarkko Nikula <jarkko.nikula@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Borislav Petkov <bp@alien8.de>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Linus Torvalds <torvalds@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 30, 2017 at 7:57 AM, Andy Lutomirski <luto@kernel.org> wrote:
> __restore_processor_context() had a couple of ordering bugs.  It
> restored GSBASE after calling load_gs_index(), and the latter can
> call into tracing code.  It also tried to restore segment registers
> before restoring the LDT, which is straight-up wrong.

Ingo, Thomas, if you apply this version, can you fix up the following
changelog bug:

>                 .seg_not_present = 1,

That should be = 0 above.

If I send a v2, I'll fix it.