From: Andy Lutomirski <luto@kernel.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Vitaly Kuznetsov" <vkuznets@redhat.com>,
"kvm list" <kvm@vger.kernel.org>, "X86 ML" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Andy Lutomirski" <luto@kernel.org>
Subject: Re: [PATCH 1/3] x86/kvm/vmx: read MSR_FS_BASE from current->thread
Date: Mon, 12 Mar 2018 16:13:40 +0000 [thread overview]
Message-ID: <CALCETrWmytXxC7tSiqCqFOs1Cvz_-u0=YVn7VoRSOr7k6kdkjA@mail.gmail.com> (raw)
In-Reply-To: <327f3194-715c-7aa7-f1bb-9ee1073f5b99@redhat.com>
On Mon, Mar 12, 2018 at 4:03 PM, Paolo Bonzini <pbonzini@redhat.com> wrote:
> On 12/03/2018 15:02, Vitaly Kuznetsov wrote:
>>
>> +/*
>> + * Currently, the only way for processes to change their FS/GS base is to call
>> + * ARCH_SET_FS/GS prctls and these reflect changes they make in task->thread.
>> + * There are, however, additional considerations:
>> + *
>> + * There is X86_BUG_NULL_SEG: on some CPUs writing '0' to FS/GS selectors zeroes
>> + * the base and on some it doesn't, we need to check for that
>> + * (see save_base_legacy()).
>> + *
>> + * When FSGSBASE extensions are enabled userspace processes will be able to
>> + * change their FS/GS bases without kernel intervention. save_fsgs() will
>> + * have to be updated to actually read FS and GS bases with RD[FG,GS]BASE
>> + * instructions.
>> + */
>> +void save_current_fsgs(void)
>> +{
>> + save_fsgs(current);
>> +}
>> +EXPORT_SYMBOL_GPL(save_current_fsgs);
>
> We don't really need save_fsgs in KVM though. We already do the
> savesegment ourselves, and we know Intel CPUs don't have
> X86_BUG_NULL_SEG. So this:
>
> savesegment(fs, vmx->host_state.fs_sel);
> if (!(vmx->host_state.fs_sel & 7)) {
> vmcs_write16(HOST_FS_SELECTOR, vmx->host_state.fs_sel);
> vmx->host_state.fs_reload_needed = 0;
> } else {
> vmcs_write16(HOST_FS_SELECTOR, 0);
> vmx->host_state.fs_reload_needed = 1;
> }
> savesegment(gs, vmx->host_state.gs_sel);
> ...
>
> could probably become simply:
>
> savesegment(fs, vmx->host_state.fs_sel);
> /*
> * When FSGSBASE extensions are enabled, this will have to use
> * RD{FS,GS}BASE instead of accessing current, and the
> * corresponding WR{FS,GS}BASE should be done unconditionally,
> * even if fs_reload_needed (resp. gs_ldt_reload_needed) is 1.
> */
> if (vmx->host_state.fs_sel <= 3) {
> vmcs_write16(HOST_FS_SELECTOR, vmx->host_state.fs_sel);
> vmcs_write16(HOST_FS_BASE, current->thread.fsbase);
> vmx->host_state.fs_reload_needed = 0;
> } else {
> vmcs_write16(HOST_FS_SELECTOR, 0);
> vmcs_write16(HOST_FS_BASE, 0);
> vmx->host_state.fs_reload_needed = 1;
> }
> savesegment(gs, vmx->host_state.gs_sel);
> ...
>
> ?
>
Hmm, probably, although this still gets the case where the user writes
0 to %fs wrong. Of course, save_fsgs() also gets that wrong.
I'm okay with this variant as long as you add a comment to
save_..._legacy pointing at the KVM code.
next prev parent reply other threads:[~2018-03-12 16:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 14:02 [PATCH 0/3] x86/kvm: avoid expensive rdmsrs for FS/GS base MSRs Vitaly Kuznetsov
2018-03-12 14:02 ` [PATCH 1/3] x86/kvm/vmx: read MSR_FS_BASE from current->thread Vitaly Kuznetsov
2018-03-12 15:34 ` Andy Lutomirski
2018-03-12 15:55 ` Vitaly Kuznetsov
2018-03-12 16:03 ` Paolo Bonzini
2018-03-12 16:13 ` Andy Lutomirski [this message]
2018-03-12 16:18 ` Paolo Bonzini
2018-03-12 17:00 ` Andy Lutomirski
2018-03-12 17:11 ` Paolo Bonzini
2018-03-13 13:20 ` Vitaly Kuznetsov
2018-03-13 13:24 ` Paolo Bonzini
2018-03-12 14:02 ` [PATCH 2/3] x86/kvm/vmx: read MSR_KERNEL_GS_BASE " Vitaly Kuznetsov
2018-03-12 14:03 ` [PATCH 3/3] x86/kvm/vmx: avoid expensive rdmsr for MSR_GS_BASE Vitaly Kuznetsov
2018-03-12 15:42 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALCETrWmytXxC7tSiqCqFOs1Cvz_-u0=YVn7VoRSOr7k6kdkjA@mail.gmail.com' \
--to=luto@kernel.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).