From: Andy Lutomirski <luto@amacapital.net>
To: Luis Rodriguez <mcgrof@suse.com>,
Konstantin Ozerkov <kozerkov@parallels.com>,
Takashi Iwai <tiwai@suse.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
ALSA development <alsa-devel@alsa-project.org>
Subject: Getting rid of inside_vm in intel8x0
Date: Tue, 29 Mar 2016 14:37:32 -0700 [thread overview]
Message-ID: <CALCETrWnsn4CoRXcKDXpMTjxCYj8==mZQHkZRuXfZQyvERB3Gw@mail.gmail.com> (raw)
Would it be possible to revert:
commit 228cf79376f13b98f2e1ac10586311312757675c
Author: Konstantin Ozerkov <kozerkov@parallels.com>
Date: Wed Oct 26 19:11:01 2011 +0400
ALSA: intel8x0: Improve performance in virtual environment
Presumably one or more of the following is true:
a) The inside_vm == true case is just an optimization and should apply
unconditionally.
b) The inside_vm == true case is incorrect and should be fixed or disabled.
c) The inside_vm == true case is a special case that makes sense then
IO is very very slow but doesn't make sense when IO is fast. If so,
why not literally measure the time that the IO takes and switch over
to the "inside VM" path when IO is slow?
There are a pile of nonsensical "are we in a VM" checks of various
sorts scattered throughout the kernel, they're all a mess to maintain
(there are lots of kinds of VMs in the world, and Linux may not even
know it's a guest), and, in most cases, it appears that the correct
solution is to delete the checks. I just removed a nasty one in the
x86_32 entry asm, and this one is written in C so it should be a piece
of cake :)
--Andy
next reply other threads:[~2016-03-29 21:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 21:37 Andy Lutomirski [this message]
2016-03-30 6:07 ` Getting rid of inside_vm in intel8x0 Takashi Iwai
2016-03-31 22:26 ` Luis R. Rodriguez
2016-04-01 5:34 ` Takashi Iwai
2016-04-01 22:28 ` Luis R. Rodriguez
2016-04-02 5:33 ` Takashi Iwai
2016-04-02 12:57 ` Andy Lutomirski
2016-04-02 16:07 ` Takashi Iwai
2016-04-02 18:05 ` Andy Lutomirski
2016-04-02 20:22 ` Takashi Iwai
2016-04-04 18:31 ` Luis R. Rodriguez
2016-04-04 9:05 ` George Dunlap
2016-04-04 9:15 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALCETrWnsn4CoRXcKDXpMTjxCYj8==mZQHkZRuXfZQyvERB3Gw@mail.gmail.com' \
--to=luto@amacapital.net \
--cc=alsa-devel@alsa-project.org \
--cc=kozerkov@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).