From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754851AbcGFOct (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Jul 2016 10:32:49 -0400
Received: from mail-vk0-f54.google.com ([209.85.213.54]:35557 "EHLO
	mail-vk0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753825AbcGFOcr (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Jul 2016 10:32:47 -0400
MIME-Version: 1.0
In-Reply-To: <20160629105736.15017-6-dsafonov@virtuozzo.com>
References: <20160629105736.15017-1-dsafonov@virtuozzo.com> <20160629105736.15017-6-dsafonov@virtuozzo.com>
From: Andy Lutomirski <luto@amacapital.net>
Date: Wed, 6 Jul 2016 07:32:26 -0700
Message-ID: <CALCETrXDZDfc2iGsn_UAgVsyGsUh5yj76E+=h3g9sK8LW5kE_A@mail.gmail.com>
Subject: Re: [PATCHv2 5/6] x86/ptrace: down with test_thread_flag(TIF_IA32)
To: Dmitry Safonov <dsafonov@virtuozzo.com>, Pedro Alves <palves@redhat.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Dmitry Safonov <0x7f454c46@gmail.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        Ingo Molnar <mingo@redhat.com>, Cyrill Gorcunov <gorcunov@openvz.org>,
        xemul@virtuozzo.com, Oleg Nesterov <oleg@redhat.com>,
        Andy Lutomirski <luto@kernel.org>, X86 ML <x86@kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 29, 2016 at 3:57 AM, Dmitry Safonov <dsafonov@virtuozzo.com> wrote:
> As the task isn't executing at the moment of {GET,SET}REGS,
> return regset that corresponds to code selector, rather than
> value of TIF_IA32 flag.
> I.e. if we ptrace i386 elf binary that has just changed it's
> code selector to __USER_CS, than GET_REGS will return
> full x86_64 register set.

Pedro, I think this will cause gdb to be a little less broken than it
is now.  Am I right?  Will this break anything?

--Andy