From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752634AbbKHQQd (ORCPT ); Sun, 8 Nov 2015 11:16:33 -0500 Received: from mail-ob0-f181.google.com ([209.85.214.181]:33841 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751500AbbKHQQb (ORCPT ); Sun, 8 Nov 2015 11:16:31 -0500 MIME-Version: 1.0 In-Reply-To: References: <42b51cafe425b8d7d177c7c363235df0ace22692.1446849780.git.luto@kernel.org> From: Andy Lutomirski Date: Sun, 8 Nov 2015 08:16:11 -0800 Message-ID: Subject: Re: [PATCH 3/4] x86/asm: Add asm macros for static keys/jump labels To: Thomas Gleixner Cc: Borislav Petkov , Frederic Weisbecker , Brian Gerst , "linux-kernel@vger.kernel.org" , X86 ML , Peter Zijlstra , Linus Torvalds Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 7, 2015 at 9:08 AM, Thomas Gleixner wrote: > On Sat, 7 Nov 2015, Andy Lutomirski wrote: >> On Sat, Nov 7, 2015 at 8:58 AM, Thomas Gleixner wrote: >> True. But I hid it in a header file, too, but it was just a different >> header file -- I had it all hidden away as CALL_ENTER_FROM_USER_MODE. > > It probably does not really make a difference :) > > I just got triggered by you saying: > >> Unfortunately, these only work if HAVE_JUMP_LABEL .... > Looking again, my patch is crappy is one obvious respect: on non-HAVE_JUMP_LABEL kernels, I'm still generating a macro that will compile but do the wrong thing. I'll add better comments and the correct ifdef in v2. That will make it much harder to screw up without causing a compiler error. --Andy