From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752009AbcEVBoY (ORCPT <rfc822;w@1wt.eu>);
	Sat, 21 May 2016 21:44:24 -0400
Received: from mail-oi0-f49.google.com ([209.85.218.49]:33683 "EHLO
	mail-oi0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751600AbcEVBoX (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 21 May 2016 21:44:23 -0400
MIME-Version: 1.0
In-Reply-To: <1463846691-18498-2-git-send-email-brgerst@gmail.com>
References: <1463846691-18498-1-git-send-email-brgerst@gmail.com> <1463846691-18498-2-git-send-email-brgerst@gmail.com>
From: Andy Lutomirski <luto@amacapital.net>
Date: Sat, 21 May 2016 18:44:02 -0700
Message-ID: <CALCETrXbdXacNJBY8uo=cRsgAFwz7h46oyLNoF+rCNRQrpKTDg@mail.gmail.com>
Subject: Re: [PATCH 1/4] x86: Save return value from kernel_thread
To: Brian Gerst <brgerst@gmail.com>
Cc: X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Denys Vlasenko <dvlasenk@redhat.com>, Borislav Petkov <bp@suse.de>,
        Thomas Gleixner <tglx@linutronix.de>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, May 21, 2016 at 9:04 AM, Brian Gerst <brgerst@gmail.com> wrote:
> Kernel threads should always return zero on success after calling do_execve().  The
> two existing cases in the kernel (kernel_init() and call_usermodehelper_exec_async())
> correctly do this.  Save a few bytes by storing EAX/RAX instead of an immediate zero.
> Also fix the 64-bit case which should save the full 64-bits.

Does this have any additional motivation beyond cleanup and fixing an
inconsequential bug?  I.e. does the rest of your series need this?

--Andy