From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756445AbbEUWZL (ORCPT ); Thu, 21 May 2015 18:25:11 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:33919 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755969AbbEUWZJ (ORCPT ); Thu, 21 May 2015 18:25:09 -0400 MIME-Version: 1.0 In-Reply-To: References: <20150515123513.16723.96340.stgit@warthog.procyon.org.uk> <555BD715.40202@kernel.org> <31772.1432128969@warthog.procyon.org.uk> <20150520162059.GC10473@localhost> <20150521213829.GH23057@wotan.suse.de> From: Andy Lutomirski Date: Thu, 21 May 2015 15:24:46 -0700 Message-ID: Subject: Re: [PATCH 0/8] MODSIGN: Use PKCS#7 for module signatures [ver #4] To: "Luis R. Rodriguez" Cc: David Howells , Andy Lutomirski , Rusty Russell , Michal Marek , Matthew Garrett , keyrings@linux-nfs.org, Dmitry Kasatkin , "linux-kernel@vger.kernel.org" , Seth Forshee , LSM List , David Woodhouse Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 21, 2015 at 3:16 PM, Luis R. Rodriguez wrote: > On Thu, May 21, 2015 at 3:06 PM, Andy Lutomirski wrote: >> Given that, I would say that merely shoving firmware files through the >> module verifier as-is would not be okay. > > Replacing one dog and pony show for another is what is going on, what > you describe and suggest seems best, and I welcome patches, it seems > you know what you are talking about :) > Don't hold your breath. My plate is over-full. I'm probably a decent reviewer of crypto, though. --Andy