From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16DADC5B57D for ; Sat, 29 Jun 2019 23:45:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E108E21743 for ; Sat, 29 Jun 2019 23:45:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561851910; bh=NO9SldPrvEHCV9L05HomDu1WyC6FUgdLlHc97KSTRsQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=MEAEKCXiykWCcgDn5NyXHC1bRJ9H5nfjCQ5emXDAD44xeOC0F3Umsgr6yzKqE9PCa CtQJnptPAoNx4GNlNnU8+QQEt7zCKmxB4NqGcPnfnf3qyTKQewEnyf2v3vL3zWOtwj etb1VVM9Qa7SNMUHciuwucSRgNqkqNpzKWmhacbE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727036AbfF2XpI (ORCPT ); Sat, 29 Jun 2019 19:45:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:57530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726953AbfF2XpH (ORCPT ); Sat, 29 Jun 2019 19:45:07 -0400 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0EB0921773 for ; Sat, 29 Jun 2019 23:45:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561851907; bh=NO9SldPrvEHCV9L05HomDu1WyC6FUgdLlHc97KSTRsQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=L9zsQCD3SME4yCdiZ91gR5mu3dTU7iHytvauDPWLVWJ5PVYhrkz4Xa1e7uv4wAgV3 dn6A6uxhscIfZ/fM0Q/M50uV8Zprd9O/fI/u2BZF1R7eLQPpJWxVUZ9macy7ZQ9u1d B6qcP8VfgVBU5+U66FxTgTcWis+nQEC2Uneo6t/g= Received: by mail-wm1-f54.google.com with SMTP id u8so12258824wmm.1 for ; Sat, 29 Jun 2019 16:45:06 -0700 (PDT) X-Gm-Message-State: APjAAAWcNmczK0uZ/1ITt+S5XQJ58unDxpN+1dzy6wi3Pyhx5rwZ4mV2 KE3uZ4SPE7t7rn/Ts1TaPx+N07+2LsUQTuKqUjUBaA== X-Google-Smtp-Source: APXvYqw7AqV0riQVWfNq9DWyOR0lQPRhOlZu5oCeDxSJhE/lHbPusIgX678jLiDRugcnqjeaEdrl0RkDIaMs4WKe0VE= X-Received: by 2002:a1c:9a53:: with SMTP id c80mr11059844wme.173.1561851905663; Sat, 29 Jun 2019 16:45:05 -0700 (PDT) MIME-Version: 1.0 References: <20190628194158.2431-1-yu-cheng.yu@intel.com> <20190628194158.2431-3-yu-cheng.yu@intel.com> In-Reply-To: <20190628194158.2431-3-yu-cheng.yu@intel.com> From: Andy Lutomirski Date: Sat, 29 Jun 2019 16:44:54 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH 3/3] Prevent user from writing to IBT bitmap. To: Yu-cheng Yu Cc: X86 ML , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , LKML , "open list:DOCUMENTATION" , Linux-MM , linux-arch , Linux API , Arnd Bergmann , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 28, 2019 at 12:50 PM Yu-cheng Yu wrote: > > The IBT bitmap is visiable from user-mode, but not writable. > > Signed-off-by: Yu-cheng Yu > > --- > arch/x86/mm/fault.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > index 59f4f66e4f2e..231196abb62e 100644 > --- a/arch/x86/mm/fault.c > +++ b/arch/x86/mm/fault.c > @@ -1454,6 +1454,13 @@ void do_user_addr_fault(struct pt_regs *regs, > * we can handle it.. > */ > good_area: > +#define USER_MODE_WRITE (FAULT_FLAG_WRITE | FAULT_FLAG_USER) > + if (((flags & USER_MODE_WRITE) == USER_MODE_WRITE) && > + (vma->vm_flags & VM_IBT)) { > + bad_area_access_error(regs, hw_error_code, address, vma); > + return; > + } > + Just make the VMA have VM_WRITE and VM_MAYWRITE clear. No new code like this should be required.