From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754353AbaKXR6q (ORCPT ); Mon, 24 Nov 2014 12:58:46 -0500 Received: from mail-lb0-f170.google.com ([209.85.217.170]:55837 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751842AbaKXR6p (ORCPT ); Mon, 24 Nov 2014 12:58:45 -0500 MIME-Version: 1.0 In-Reply-To: <20141122165501.GB4395@pd.tnic> References: <4eb18b212f8f62d0ea3dc0679930ede82d7d37fc.1416604491.git.luto@amacapital.net> <20141122165501.GB4395@pd.tnic> From: Andy Lutomirski Date: Mon, 24 Nov 2014 09:58:23 -0800 Message-ID: Subject: Re: [PATCH v4 1/5] uprobes, x86: Fix _TIF_UPROBE vs _TIF_NOTIFY_RESUME To: Borislav Petkov Cc: X86 ML , Linus Torvalds , "linux-kernel@vger.kernel.org" , Peter Zijlstra , Oleg Nesterov , Tony Luck , Andi Kleen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Nov 22, 2014 at 8:55 AM, Borislav Petkov wrote: > On Fri, Nov 21, 2014 at 01:26:07PM -0800, Andy Lutomirski wrote: >> x86 call do_notify_resume on paranoid returns if TIF_UPROBE is set >> but not on non-paranoid returns. I suspect that this is a mistake >> and that the code only works because int3 is paranoid. >> >> Setting _TIF_NOTIFY_RESUME in the uprobe code was probably a >> workaround for the x86 bug. With that bug fixed, we can remove >> _TIF_NOTIFY_RESUME from the uprobes code. >> >> Acked-by: Srikar Dronamraju >> Reported-by: Oleg Nesterov >> Signed-off-by: Andy Lutomirski > > Acked-by: Borislav Petkov > This one is now upstream, so I'm dropping it. --Andy > -- > Regards/Gruss, > Boris. > > Sent from a fat crate under my desk. Formatting is fine. > -- -- Andy Lutomirski AMA Capital Management, LLC