From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751975AbcFZRAH (ORCPT ); Sun, 26 Jun 2016 13:00:07 -0400 Received: from mail-vk0-f42.google.com ([209.85.213.42]:32924 "EHLO mail-vk0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460AbcFZRAF (ORCPT ); Sun, 26 Jun 2016 13:00:05 -0400 MIME-Version: 1.0 In-Reply-To: <20160624153503.oeivkn7djnxdi5oq@treble> References: <20160624153503.oeivkn7djnxdi5oq@treble> From: Andy Lutomirski Date: Sun, 26 Jun 2016 09:59:44 -0700 Message-ID: Subject: Re: [PATCH v4 13/16] x86/dumpstack: Try harder to get a call trace on stack overflow To: Josh Poimboeuf Cc: Andy Lutomirski , X86 ML , "linux-kernel@vger.kernel.org" , linux-arch , Borislav Petkov , Nadav Amit , Kees Cook , Brian Gerst , "kernel-hardening@lists.openwall.com" , Linus Torvalds , Jann Horn , Heiko Carstens Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 24, 2016 at 8:35 AM, Josh Poimboeuf wrote: > On Thu, Jun 23, 2016 at 09:23:08PM -0700, Andy Lutomirski wrote: >> If we overflow the stack, print_context_stack will abort. Detect >> this case and rewind back into the valid part of the stack so that >> we can trace it. >> >> Signed-off-by: Andy Lutomirski > > Reviewed-by: Josh Poimboeuf > FWIW, I'm making a trivial change here for v4: task->stack -> task_stack_page(task). Since it seems inconsequential, I'm keeping your reviewed-by. > -- > Josh -- Andy Lutomirski AMA Capital Management, LLC