From: Ezequiel Garcia <elezegarcia@gmail.com>
To: Peter Senna Tschudin <peter.senna@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
kernel-janitors@vger.kernel.org, Julia.Lawall@lip6.fr,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code
Date: Wed, 5 Sep 2012 16:33:10 -0300 [thread overview]
Message-ID: <CALF0-+VRin4LrR-9zuXro2MJ2wePkw40SSD=vrqrsrSFTsgSAg@mail.gmail.com> (raw)
In-Reply-To: <1346775269-12191-4-git-send-email-peter.senna@gmail.com>
Hi Peter,
On Tue, Sep 4, 2012 at 1:14 PM, Peter Senna Tschudin
<peter.senna@gmail.com> wrote:
> From: Peter Senna Tschudin <peter.senna@gmail.com>
>
> Convert a nonnegative error return code to a negative one, as returned
> elsewhere in the function.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
> ret@p1 = 0
> )
> ... when != ret = e1
> when != &ret
> *if(...)
> {
> ... when != ret = e2
> when forall
> return ret;
> }
>
> // </smpl>
>
> Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
>
> ---
> drivers/media/platform/s5p-tv/sdo_drv.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/s5p-tv/sdo_drv.c b/drivers/media/platform/s5p-tv/sdo_drv.c
> index ad68bbe..58cf56d 100644
> --- a/drivers/media/platform/s5p-tv/sdo_drv.c
> +++ b/drivers/media/platform/s5p-tv/sdo_drv.c
> @@ -369,6 +369,7 @@ static int __devinit sdo_probe(struct platform_device *pdev)
> sdev->fout_vpll = clk_get(dev, "fout_vpll");
> if (IS_ERR_OR_NULL(sdev->fout_vpll)) {
> dev_err(dev, "failed to get clock 'fout_vpll'\n");
> + ret = -ENODEV;
> goto fail_dacphy;
> }
> dev_info(dev, "fout_vpll.rate = %lu\n", clk_get_rate(sclk_vpll));
> @@ -377,11 +378,13 @@ static int __devinit sdo_probe(struct platform_device *pdev)
> sdev->vdac = devm_regulator_get(dev, "vdd33a_dac");
> if (IS_ERR_OR_NULL(sdev->vdac)) {
> dev_err(dev, "failed to get regulator 'vdac'\n");
> + ret = -ENODEV;
> goto fail_fout_vpll;
> }
> sdev->vdet = devm_regulator_get(dev, "vdet");
> if (IS_ERR_OR_NULL(sdev->vdet)) {
> dev_err(dev, "failed to get regulator 'vdet'\n");
> + ret = -ENODEV;
> goto fail_fout_vpll;
> }
>
>
Just a nitpick: why using ENODEV when the rest of the function is using ENXIO?
In which case, you could fix this with a less intrusive change, by
initializating ret to -ENXIO.
Hope this helps,
Ezequiel.
next prev parent reply other threads:[~2012-09-05 19:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 16:14 [PATCH 2/5] drivers/media/platform/s5p-tv/sdo_drv.c: fix error return code Peter Senna Tschudin
2012-09-05 19:33 ` Ezequiel Garcia [this message]
2012-09-06 8:38 ` [PATCH v2] " Peter Senna Tschudin
2012-09-23 19:30 ` Fwd: " Mauro Carvalho Chehab
2012-09-24 10:00 ` Sylwester Nawrocki
2012-09-24 9:16 ` Tomasz Stanislawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALF0-+VRin4LrR-9zuXro2MJ2wePkw40SSD=vrqrsrSFTsgSAg@mail.gmail.com' \
--to=elezegarcia@gmail.com \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=peter.senna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).