From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_MED, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DF81C46471 for ; Mon, 6 Aug 2018 12:37:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FAD6219EF for ; Mon, 6 Aug 2018 12:37:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=embeddedgreg-com.20150623.gappssmtp.com header.i=@embeddedgreg-com.20150623.gappssmtp.com header.b="bAMqsVNM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3FAD6219EF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=embeddedgreg.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731298AbeHFOqq (ORCPT ); Mon, 6 Aug 2018 10:46:46 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:35829 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726887AbeHFOqq (ORCPT ); Mon, 6 Aug 2018 10:46:46 -0400 Received: by mail-oi0-f67.google.com with SMTP id m11-v6so21904956oic.2 for ; Mon, 06 Aug 2018 05:37:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embeddedgreg-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=89ia0iP3NKGT1f415wnsh7B+eGYaSxuXNRIofakmcRY=; b=bAMqsVNMK2kaHZnz8b7oMLE7+x1+G2pqgVg463YDy+BXq9uyPC3SNlg7iVVWxxcXgK kGxnCLDp1qUlPn6L8I+Xd1cHlurTaW/AyghQ4rUcMYK3pq6I6CW5GW0fkwdURF/kro+z izjNdCoR9JQsk4BQoC4gyzKOpxHPg92mc/NqXeLx5fmGfmWPwzhTFp/OZ75R5uYU2Sbx J6DO2cQzB/PNBf74F3DHwE8wwLONTzHnH+Y4qupS7arSdifI6tCIBsAB03/uz2PzNZZ/ bddIvO9YWhk14eSXBw8NugS1iY6mdtOk1Q7iN4/h4z2pq77uUlJw9CPZFTEZhjP4/bSQ bZDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=89ia0iP3NKGT1f415wnsh7B+eGYaSxuXNRIofakmcRY=; b=DOovcMTXkjT09JdeG8SdkurId+E3KuG9zJgh+udPSjIN89o33D9PQNu/kMyP65zWME fHmPVnAObKuNqCXS2jhBbcOlTxvSHBlW5IgILxx6ATPfMbqsvr6iEVhioenDv1wP7SZk dKJiXnyLBVfsxErziHJ1Z3J9SQV55sjQvphrU8pvCFYLcZtQAbsTwQ8vLa9VnSWuK+8D C6VfAX09pBSA3eo4+oOI5y70RjWkKZIr4MaoaQVOLkEC7S1RKCOfBTwYhLxDx8Me78gu GVNBkg+GqhE1g3JMGJbMDZ9/AITQOAPz1r6ZE5y3tZYyI57eSbP6UHTaFkpoLj+Ssegf ctNw== X-Gm-Message-State: AOUpUlH/nhiqpefAg/jOPbkfRwJk8ZZ7EzwBwn7ttbDLm7efyc6G6gM3 UWtFTpVh/XaVb5/FvH/9bum2vlyqOVRh0CBs4Ddm0TwWUYXbHA== X-Google-Smtp-Source: AAOMgpd9wXz0YhPQeeUUoUA49YmdHdoDMHu9Irrsvd6CZupvIH2uEcH6rK04uJT4KJ6fyxPHsodCFNkeynVg/dJSTk8= X-Received: by 2002:aca:d088:: with SMTP id j8-v6mr14690554oiy.276.1533559069687; Mon, 06 Aug 2018 05:37:49 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:8afa:0:0:0:0:0 with HTTP; Mon, 6 Aug 2018 05:37:49 -0700 (PDT) In-Reply-To: References: <20180806040731.5113-1-greg@embeddedgreg.com> From: Greg Gallagher Date: Mon, 6 Aug 2018 08:37:49 -0400 Message-ID: Subject: Re: [PATCH] staging/vc04_services: Fix alignment of function arguments To: Stefan Wahren Cc: Eric Anholt , Greg Kroah-Hartman , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Aug 6, 2018 at 4:34 AM, Stefan Wahren wrote: > Hi, > > Am 06.08.2018 um 06:07 schrieb Greg Gallagher: >> >> Fix warning generated by checkpatch.pl for alignment should match open >> parenthesis. This is a coding style change only. >> >> Signed-off-by: Greg Gallagher >> --- >> drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c >> b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c >> index ec468d5719b1..33ae8ae8663b 100644 >> --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c >> +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-ctl.c >> @@ -174,7 +174,7 @@ static struct snd_kcontrol_new snd_bcm2835_ctl[] = { >> }; >> static int snd_bcm2835_spdif_default_info(struct snd_kcontrol >> *kcontrol, >> - struct snd_ctl_elem_info *uinfo) >> + struct snd_ctl_elem_info *uinfo) >> { >> uinfo->type = SNDRV_CTL_ELEM_TYPE_IEC958; >> uinfo->count = 1; > > > in case this is the only alignment issue in the whole driver, you can have > my acked-by. > Otherwise please fix the other ones in the second version. > > Btw there are more drivers under vc04_services so a "staging: bcm2835-audio: > Fix alignment of functions arguments" would be better. > > Stefan I'll fix the other alignment issues as well in the second version and fix up the subject line to staging: bcm2835-audio. thanks Greg