From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF06EC432BE for ; Sun, 22 Aug 2021 17:04:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CBFEF61266 for ; Sun, 22 Aug 2021 17:04:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231287AbhHVRFM (ORCPT ); Sun, 22 Aug 2021 13:05:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbhHVRFK (ORCPT ); Sun, 22 Aug 2021 13:05:10 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC27EC061575; Sun, 22 Aug 2021 10:04:28 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id s25so9662836edw.0; Sun, 22 Aug 2021 10:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pUhcEqU+ZOQSh1pqtcVaDKol4jZl9qqosLL03IwQCwI=; b=SRURG8Ghxgf5zrl/KaywI4BeZ6O6ZKJ/YWBoWfw95lgv1yIX38ujGtFadm/yWGRWyY pA4q+PMZ6hT/63AyNXzHJaprwRpH9aZm1lVXZSS1Gt3PjfhyONRPF78zB0pLI+yqZoFz 3h9J88w6UdMWzKCX0vC53H+ZLfYxiatFuVYIDpgdLhhX8kPi/Vzfz6Uz2zEvuuraokd/ wfZacbH06ThR+6r6RltOisIArPam00kaYeBBvzau99L0q7Qnzs363rz3v972bDFn0iUW 4d79ghP8VPvnpIJnHMIGPfgS86dlfxc+FPCIwghszS7BdxxmsYeRpRpTre46L7/ljTCF BfLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pUhcEqU+ZOQSh1pqtcVaDKol4jZl9qqosLL03IwQCwI=; b=QcOARvrn+6ix/rlazamaHrz4zIdxg5kOUP8IB2IiESej6HIeaobbxXBZUH3Ao3rG9L ceBgNXtSoWrO1CO9yUKy32h7wdLbM9qkUHHc5EB4cAKMt5rxAU+7a22zzMin3A3xYFUC LR4d48eNSXyrk1r5sTWH0FScNcV8oM9h/v24jJn30pra4X3Z8sM0jJX/CEtfiiJTub6Z aX25K3VHIf1q3ZVUd8K/l1RiRDaOk8oaYPVUdZjBJe9x6oXtETdHUmZvUZ6cwa7jTZRm qLKimDkYCkNllXLmFMbDuuDNKbq4R/j6nd4PluzFdUKdW+j+punE1YfaFCLnJQ5idgAh 3RVQ== X-Gm-Message-State: AOAM5302LOAZL3KcYctSqjB5lj1yBF0En/ZLWbfhhI+EAAv6zc7u5mZC xNdDJxWJUWfTgB4xwCVDMCv/WKVtA8NF50FCeV0= X-Google-Smtp-Source: ABdhPJz+Rhplwjyhy1l+jgu+LHSgx/fM/lmZPSaoqLXETlHorGhUoDm8C4GnJ9XjXSJoeidJAjOsVAEUOZbjqO5Eqpo= X-Received: by 2002:aa7:d681:: with SMTP id d1mr33905628edr.186.1629651867490; Sun, 22 Aug 2021 10:04:27 -0700 (PDT) MIME-Version: 1.0 References: <77f3e358-c75e-b0bf-ca87-6f8297f5593c@virtuozzo.com> In-Reply-To: From: Christoph Paasch Date: Sun, 22 Aug 2021 10:04:16 -0700 Message-ID: Subject: Re: [PATCH NET v4 3/7] ipv6: use skb_expand_head in ip6_xmit To: Vasily Averin Cc: "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Eric Dumazet , netdev , LKML , kernel@openvz.org, Julian Wiedmann Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Vasily, On Fri, Aug 20, 2021 at 11:21 PM Vasily Averin wrote: > > On 8/21/21 1:44 AM, Christoph Paasch wrote: > > (resend without html - thanks gmail web-interface...) > > On Fri, Aug 20, 2021 at 3:41 PM Christoph Paasch > >> AFAICS, this is because pskb_expand_head (called from > >> skb_expand_head) is not adjusting skb->truesize when skb->sk is set > >> (which I guess is the case in this particular scenario). I'm not > >> sure what the proper fix would be though... > > Could you please elaborate? > it seems to me skb_realloc_headroom used before my patch called pskb_expand_head() too > and did not adjusted skb->truesize too. Am I missed something perhaps? > > The only difference in my patch is that skb_clone can be not called, > though I do not understand how this can affect skb->truesize. I *believe* that the difference is that after skb_clone() skb->sk is NULL and thus truesize will be adjusted. I will try to confirm that with some more debugging. Christoph > > Thank you, > Vasily Averin