From: Jim Mattson <jmattson@google.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: "kvm list" <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Joerg Roedel" <joro@8bytes.org>
Subject: Re: [PATCH RFC 2/5] x86: KVM: svm: avoid flooding logs when skip_emulated_instruction() fails
Date: Thu, 20 Jun 2019 11:45:36 -0700 [thread overview]
Message-ID: <CALMp9eQh3yJZbDkSj2pQ4xrq=ZJc9rBsqdL2B7nJf-_p6+R3Tg@mail.gmail.com> (raw)
In-Reply-To: <20190620110240.25799-3-vkuznets@redhat.com>
On Thu, Jun 20, 2019 at 4:02 AM Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>
> When we're unable to skip instruction with kvm_emulate_instruction() we
> will not advance RIP and most likely the guest will get stuck as
> consequitive attempts to execute the same instruction will likely result
> in the same behavior.
>
> As we're not supposed to see these messages under normal conditions, switch
> to pr_err_once().
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
next prev parent reply other threads:[~2019-06-20 18:45 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 11:02 [PATCH RFC 0/5] x86/KVM/svm: get rid of hardcoded instructions lengths Vitaly Kuznetsov
2019-06-20 11:02 ` [PATCH RFC 1/5] x86: KVM: svm: don't pretend to advance RIP in case wrmsr_interception() results in #GP Vitaly Kuznetsov
2019-06-20 18:49 ` Jim Mattson
2019-06-21 8:42 ` Vitaly Kuznetsov
2019-06-20 11:02 ` [PATCH RFC 2/5] x86: KVM: svm: avoid flooding logs when skip_emulated_instruction() fails Vitaly Kuznetsov
2019-06-20 18:45 ` Jim Mattson [this message]
2019-06-20 11:02 ` [PATCH RFC 3/5] x86: KVM: svm: clear interrupt shadow on all paths in skip_emulated_instruction() Vitaly Kuznetsov
2019-06-20 18:44 ` Jim Mattson
2019-06-21 8:43 ` Vitaly Kuznetsov
2019-07-31 13:50 ` Vitaly Kuznetsov
2019-07-31 16:37 ` Paolo Bonzini
2019-07-31 20:27 ` Jim Mattson
2019-07-31 23:37 ` Sean Christopherson
2019-07-31 23:45 ` Jim Mattson
2019-07-31 23:56 ` Sean Christopherson
2019-08-01 0:13 ` Paolo Bonzini
2019-08-01 0:17 ` Jim Mattson
2019-06-20 11:02 ` [PATCH RFC 4/5] x86: KVM: add xsetbv to the emulator Vitaly Kuznetsov
2019-06-20 12:18 ` Paolo Bonzini
2019-07-31 13:07 ` Vitaly Kuznetsov
2019-07-31 13:14 ` Paolo Bonzini
2019-06-20 11:02 ` [PATCH RFC 5/5] x86: KVM: svm: remove hardcoded instruction length from intercepts Vitaly Kuznetsov
2019-06-20 18:41 ` Jim Mattson
2019-06-20 12:14 ` [PATCH RFC 0/5] x86/KVM/svm: get rid of hardcoded instructions lengths Paolo Bonzini
2019-06-20 12:26 ` Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALMp9eQh3yJZbDkSj2pQ4xrq=ZJc9rBsqdL2B7nJf-_p6+R3Tg@mail.gmail.com' \
--to=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).