From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A004C33C9E for ; Mon, 6 Jan 2020 20:16:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F318C222D9 for ; Mon, 6 Jan 2020 20:16:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="MyzLiAmq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726751AbgAFUQM (ORCPT ); Mon, 6 Jan 2020 15:16:12 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:43213 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726657AbgAFUQM (ORCPT ); Mon, 6 Jan 2020 15:16:12 -0500 Received: by mail-io1-f65.google.com with SMTP id n21so48384629ioo.10 for ; Mon, 06 Jan 2020 12:16:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3GDssrbOe7NhLbjc31VdhTYmJ4APDSoT1K50tZqydr0=; b=MyzLiAmqcB1hgGyIZ2kA3LgpI/ZSjANJzdcs1E5c5RVxxQpmwsDvEnjbnSPf9jbIaW aZNpmuz3zw/Z5pUWgUqycvYCSe9haPGYbOfusaBHGgskL1dn/gdIuMkH/QAyWiqepbOQ c5sxvDp55U/n1xAMz7p66SDcczWPcU8K9P0u3Fz0pCxmXjd9qEOHeSgngs6MKjOXjDeV /Zy3JIpe6USdeCiSjEpNFWN5kUIwJBp0BlHVQHLIdIhny5pNstWpDTQ200QnGdA7PQ9T y/8mJlAL5lwTCg/LPC8HLJ1SD1ccAwJ9MMZBjsqtvgzohBC0B6jB2CCZzwYJMQBTK26c ekXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3GDssrbOe7NhLbjc31VdhTYmJ4APDSoT1K50tZqydr0=; b=iWyPpx4dnS9R4uejyCb8D6iv9jQKRMKo2javbecEpyR6hrNM8TWTSHNSryKR84IZ+D m+RHA4a9OwmeaXGZPiC2W0s6no6WQSj9MurBoWNYI4boc4idS9VCL0i0cMfwUeuPr13+ mBcvM7xoCn6LAKyrycSBOouNRZosAjS1m/IFoQZqQ/jMp3mkTrMMOYzU/khacnbZPJyA BOaEFM6f2lAeOM8JoYYBUAom1VKAsQ5/G3z9yJZrlwtWgGw/g5Q+/dmFYPJwbsy85aVB t0T1ar4raHWX3pTEfECu3BBRd4CJg2psYucwAclBJX+mLRbJwjK1PIua08N4qi0tB/0A rN+w== X-Gm-Message-State: APjAAAX/9iNSlTII8iPXLuyc8GA2hmgIfYxYxKY8RFw/0poKYOlIBt2d G3XJbtBkQx2nOi2lpHIcfukCB7S0IkcYEFYrKIEyOA== X-Google-Smtp-Source: APXvYqwR3dKEBj0osCR3tSkV2tqMs2o30CYmbwv2DVudSSvgXPx/sQElULEAO3+ccHMeZ91xIWFF4B+jFbSXGtFy/ig= X-Received: by 2002:a6b:740c:: with SMTP id s12mr30491676iog.108.1578341771601; Mon, 06 Jan 2020 12:16:11 -0800 (PST) MIME-Version: 1.0 References: <20191211204753.242298-1-pomonis@google.com> <20191211204753.242298-2-pomonis@google.com> In-Reply-To: <20191211204753.242298-2-pomonis@google.com> From: Jim Mattson Date: Mon, 6 Jan 2020 12:16:00 -0800 Message-ID: Subject: Re: [PATCH v2 01/13] KVM: x86: Protect x86_decode_insn from Spectre-v1/L1TF attacks To: Marios Pomonis Cc: Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "the arch/x86 maintainers" , kvm list , LKML , Nick Finco , Andrew Honig , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 11, 2019 at 12:48 PM Marios Pomonis wrote: > > This fixes a Spectre-v1/L1TF vulnerability in x86_decode_insn(). > kvm_emulate_instruction() (an ancestor of x86_decode_insn()) is an exported > symbol, so KVM should treat it conservatively from a security perspective. > > Fixes: commit 045a282ca415 ("KVM: emulator: implement fninit, fnstsw, fnstcw") > > Signed-off-by: Nick Finco > Signed-off-by: Marios Pomonis > Reviewed-by: Andrew Honig > Cc: stable@vger.kernel.org Reviewed-by: Jim Mattson