From: Yafang Shao <laoar.shao@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Kees Cook <keescook@chromium.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
acme <acme@kernel.org>, kernel test robot <oliver.sang@intel.com>,
0day robot <lkp@intel.com>, Petr Mladek <pmladek@suse.com>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kernel <linux-kernel@vger.kernel.org>,
lkp <lkp@lists.01.org>, Andrew Morton <akpm@linux-foundation.org>,
Valentin Schneider <valentin.schneider@arm.com>,
Qiang Zhang <qiang.zhang@windriver.com>,
robdclark <robdclark@chromium.org>,
christian <christian@brauner.io>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
bristot <bristot@redhat.com>,
aubrey li <aubrey.li@linux.intel.com>,
yu c chen <yu.c.chen@intel.com>
Subject: Re: [sched.h] 317419b91e: perf-sanity-tests.Parse_sched_tracepoints_fields.fail
Date: Fri, 15 Oct 2021 10:20:56 +0800 [thread overview]
Message-ID: <CALOAHbAyLQ-NkeyERjs=PbaRAC7Qf=BO4KeDWfMxcB2QCTOcRQ@mail.gmail.com> (raw)
In-Reply-To: <20211014221409.5da58a42@oasis.local.home>
On Fri, Oct 15, 2021 at 10:14 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Fri, 15 Oct 2021 10:05:56 +0800
> Yafang Shao <laoar.shao@gmail.com> wrote:
>
> > > I'd say we need a TASK_COMM_LEN_V1 to use in all the old hard-coded
> > > places.
> > >
> >
> > Sure, it will be easy to grep then.
>
> Just because I'm picky about my bikeshed colors...
>
>
> Perhaps have it called TASK_COMM_LEN_16 ?
>
> The reason being, I have no idea what "V1" is. Version 1? What's that
> mean? And now TASK_COMM_LEN can be either 16 or 24. Perhaps we can have
> it be:
>
> #define TASK_COMM_LEN_16 16
> #define TASK_COMM_LEN_24 24
>
> if CONFIG_BASE_SMALL
> #define TASK_COMM_LEN TASK_COMM_LEN_16
> #else
> #define TASK_COMM_LEN TASK_COMM_LEN_24
> #endif
>
> or call it TASK_COMM_LEN_SMALL and TASK_COMM_LEN_LARGE
>
> ??
>
> It's still "grepable"
>
Good idea.
It seems TASK_COMM_LEN_16 and TASK_COMM_LEN_24 are more clear.
I will do it as you suggested.
--
Thanks
Yafang
next prev parent reply other threads:[~2021-10-15 2:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-10 10:24 [PATCH v3 0/4] task_struct: extend task comm from 16 to 24 for CONFIG_BASE_FULL Yafang Shao
2021-10-10 10:24 ` [PATCH v3 1/4] connector: use __get_task_comm in proc_comm_connector Yafang Shao
2021-10-10 10:24 ` [PATCH v3 2/4] fs/exec: use strscpy instead of strlcpy in __set_task_comm Yafang Shao
2021-10-10 10:24 ` [PATCH v3 3/4] sched.h: extend task comm from 16 to 24 for CONFIG_BASE_FULL Yafang Shao
2021-10-14 7:27 ` [sched.h] 317419b91e: perf-sanity-tests.Parse_sched_tracepoints_fields.fail kernel test robot
2021-10-14 9:24 ` Yafang Shao
2021-10-14 12:42 ` Mathieu Desnoyers
2021-10-14 13:05 ` Yafang Shao
2021-10-14 13:09 ` Mathieu Desnoyers
2021-10-14 13:11 ` Yafang Shao
2021-10-14 13:50 ` Mathieu Desnoyers
2021-10-14 14:40 ` Yafang Shao
2021-10-14 14:48 ` Steven Rostedt
2021-10-14 15:05 ` Yafang Shao
2021-10-14 16:14 ` Kees Cook
2021-10-15 2:05 ` Yafang Shao
2021-10-15 2:14 ` Steven Rostedt
2021-10-15 2:20 ` Yafang Shao [this message]
2021-10-19 16:51 ` Arnaldo Carvalho de Melo
2021-10-20 4:01 ` Yafang Shao
2021-10-10 10:24 ` [PATCH v3 4/4] kernel/kthread: show a warning if kthread's comm is truncated Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALOAHbAyLQ-NkeyERjs=PbaRAC7Qf=BO4KeDWfMxcB2QCTOcRQ@mail.gmail.com' \
--to=laoar.shao@gmail.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aubrey.li@linux.intel.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=christian@brauner.io \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lkp@lists.01.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=oliver.sang@intel.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=qiang.zhang@windriver.com \
--cc=robdclark@chromium.org \
--cc=rostedt@goodmis.org \
--cc=valentin.schneider@arm.com \
--cc=vincent.guittot@linaro.org \
--cc=viro@zeniv.linux.org.uk \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).