From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7802DC433F5 for ; Fri, 15 Oct 2021 02:21:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56A63610E8 for ; Fri, 15 Oct 2021 02:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234971AbhJOCXj (ORCPT ); Thu, 14 Oct 2021 22:23:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234892AbhJOCXi (ORCPT ); Thu, 14 Oct 2021 22:23:38 -0400 Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BCE19C061570 for ; Thu, 14 Oct 2021 19:21:32 -0700 (PDT) Received: by mail-io1-xd2b.google.com with SMTP id 188so6057987iou.12 for ; Thu, 14 Oct 2021 19:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U+0FJAOBVbzmlxq86UJy2VhVjXmI/y5S7VtIfFQ8H/Q=; b=F8Oe+jdxcrtcyMpFIqmvIFJkeU1U30c+0Tr6nBEkXS9X6APUldT6H491EbG9e91FOo TdET+iGUeDfLDnh/h+9wSO33DeaDtqmLtU9gd0Pq9nh8ub7CmAgu8LP3uS0xzObeEGLy fGjJzYTmx0tvuLtjz+L6WFk8iLwju0zI66A7C4WJzKMsqeRn4IxzQE4BKCaqNIbfl/8m towkD7TEVvBww/O3C4gZA+W7/DBo7NXnr5fIrzK6L5oZnFrxGfZbCOszDWou8SxP4qoW CK0Tt5z67thWxUftabnT6/8OqbqsYrprT78lMbQwJX+XWpQf77cjKc2hgdE3NDW3OMWV PcpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U+0FJAOBVbzmlxq86UJy2VhVjXmI/y5S7VtIfFQ8H/Q=; b=8PSVIhipbIEBHCeSJeHz+odvWTnf5pQfaJbrBV7pgVajbqBlGCc5tX/ItvEYrjLtFP w0GNeSjjgN6zvSC3gzYtz5FNLBcK5qaJgIpM/tPl8niSbNSnYn+xfCncFClFIH/p7aqE QN/s2vwXw4Yow8IpQihOiDiQIJWsfsNuB4p/wN5pDPkOUYzLEOMx1qbSdPgs/6T1DQn1 or3G55MWEtIsgiZnDQyjxa+neT5QnwOV0U1RR3AdkEfDMpFpN0HJDiG17ecgGds8VBRD EX3dpSd2DfBaxGNs7ZjOkwk7bXIsltvYqfo4rcF4tewGAnYzuKiFHU4kPRQ5rbNogMfO Mh/Q== X-Gm-Message-State: AOAM5321ASfGzEpRTa4q2WtWYityh8FFBvZqNPpTgmEEkrVolMyK2BHp +qJN6BfodWHtFrnZfQkre+A3zgCsWWqoDWMzXzk= X-Google-Smtp-Source: ABdhPJyCerH1ljCjkuEQgpL5KNsfPgFAlAjEzkcV6GmJofjdLDvWBUQ/LpHKjelSk8SuV4oAHQPv0a06AvoLtm3UmHs= X-Received: by 2002:a5e:9b18:: with SMTP id j24mr1968027iok.202.1634264492138; Thu, 14 Oct 2021 19:21:32 -0700 (PDT) MIME-Version: 1.0 References: <20211010102429.99577-4-laoar.shao@gmail.com> <20211014072707.GA18719@xsang-OptiPlex-9020> <1529739526.13983.1634215325995.JavaMail.zimbra@efficios.com> <173454728.14036.1634216949862.JavaMail.zimbra@efficios.com> <1171592945.14099.1634219447199.JavaMail.zimbra@efficios.com> <202110140910.295E856@keescook> <20211014221409.5da58a42@oasis.local.home> In-Reply-To: <20211014221409.5da58a42@oasis.local.home> From: Yafang Shao Date: Fri, 15 Oct 2021 10:20:56 +0800 Message-ID: Subject: Re: [sched.h] 317419b91e: perf-sanity-tests.Parse_sched_tracepoints_fields.fail To: Steven Rostedt Cc: Kees Cook , Mathieu Desnoyers , acme , kernel test robot , 0day robot , Petr Mladek , Peter Zijlstra , Alexander Viro , linux-kernel , lkp , Andrew Morton , Valentin Schneider , Qiang Zhang , robdclark , christian , Dietmar Eggemann , Ingo Molnar , Juri Lelli , Vincent Guittot , Ben Segall , Mel Gorman , bristot , aubrey li , yu c chen Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 15, 2021 at 10:14 AM Steven Rostedt wrote: > > On Fri, 15 Oct 2021 10:05:56 +0800 > Yafang Shao wrote: > > > > I'd say we need a TASK_COMM_LEN_V1 to use in all the old hard-coded > > > places. > > > > > > > Sure, it will be easy to grep then. > > Just because I'm picky about my bikeshed colors... > > > Perhaps have it called TASK_COMM_LEN_16 ? > > The reason being, I have no idea what "V1" is. Version 1? What's that > mean? And now TASK_COMM_LEN can be either 16 or 24. Perhaps we can have > it be: > > #define TASK_COMM_LEN_16 16 > #define TASK_COMM_LEN_24 24 > > if CONFIG_BASE_SMALL > #define TASK_COMM_LEN TASK_COMM_LEN_16 > #else > #define TASK_COMM_LEN TASK_COMM_LEN_24 > #endif > > or call it TASK_COMM_LEN_SMALL and TASK_COMM_LEN_LARGE > > ?? > > It's still "grepable" > Good idea. It seems TASK_COMM_LEN_16 and TASK_COMM_LEN_24 are more clear. I will do it as you suggested. -- Thanks Yafang