From: Yafang Shao <laoar.shao@gmail.com>
To: Tony Lu <tonylu@linux.alibaba.com>
Cc: Eric Dumazet <edumazet@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
mingo@redhat.com, netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tcp: remove redundant new line from tcp_event_sk_skb
Date: Fri, 8 Nov 2019 20:43:04 +0800 [thread overview]
Message-ID: <CALOAHbByAFM5_L4sT8AKz0M1cTWjocceo2OwWcfasT+5nM=Eyg@mail.gmail.com> (raw)
In-Reply-To: <20191108095007.26187-1-tonylu@linux.alibaba.com>
On Fri, Nov 8, 2019 at 6:12 PM Tony Lu <tonylu@linux.alibaba.com> wrote:
>
> This removes '\n' from trace event class tcp_event_sk_skb to avoid
> redundant new blank line and make output compact.
>
> Signed-off-by: Tony Lu <tonylu@linux.alibaba.com>
Thanks for pointing this out.
Reviewed-by: Yafang Shao <laoar.shao@gmail.com>
> ---
> include/trace/events/tcp.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/tcp.h b/include/trace/events/tcp.h
> index 2bc9960a31aa..cf97f6339acb 100644
> --- a/include/trace/events/tcp.h
> +++ b/include/trace/events/tcp.h
> @@ -86,7 +86,7 @@ DECLARE_EVENT_CLASS(tcp_event_sk_skb,
> sk->sk_v6_rcv_saddr, sk->sk_v6_daddr);
> ),
>
> - TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s\n",
> + TP_printk("sport=%hu dport=%hu saddr=%pI4 daddr=%pI4 saddrv6=%pI6c daddrv6=%pI6c state=%s",
> __entry->sport, __entry->dport, __entry->saddr, __entry->daddr,
> __entry->saddr_v6, __entry->daddr_v6,
> show_tcp_state_name(__entry->state))
> --
> 2.24.0
>
prev parent reply other threads:[~2019-11-08 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 9:50 [PATCH] tcp: remove redundant new line from tcp_event_sk_skb Tony Lu
2019-11-08 12:22 ` Eric Dumazet
2019-11-09 10:34 ` Tony Lu
2019-11-08 12:43 ` Yafang Shao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALOAHbByAFM5_L4sT8AKz0M1cTWjocceo2OwWcfasT+5nM=Eyg@mail.gmail.com' \
--to=laoar.shao@gmail.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tonylu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).