From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9809C77B61 for ; Mon, 24 Apr 2023 13:07:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231767AbjDXNHA (ORCPT ); Mon, 24 Apr 2023 09:07:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231184AbjDXNG6 (ORCPT ); Mon, 24 Apr 2023 09:06:58 -0400 Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A88A13C3A for ; Mon, 24 Apr 2023 06:06:57 -0700 (PDT) Received: by mail-qt1-x830.google.com with SMTP id d75a77b69052e-3ef31924c64so1522161cf.1 for ; Mon, 24 Apr 2023 06:06:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682341617; x=1684933617; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Lx287Xzo7DZ7IW3RRrRsJADrJLhhrPWkHx34Ztc5z84=; b=LjmStF4s7OufMlj5ZN6s3ojcLTDs9E7a1Xin1UPDfgciBGXYjQnFXRCLIpgaA4p1jO mgYV+tkjrYi+vyDr4cE6YW95t78Bp7uqfuKYADLMbIptB15Deuti+rACxBB6hQmjPin4 9KxwX5v64M1I3YRxCHMRWhZe7OE4TDHSObS0PV0Y5bTCA+y+z6LBSDLyn2N95hygguIq 9VD87C3Eb1EkJEnUQqlxXIsHM/wHYBESB7v2A+tuZyQs84ob6iWJGmzQLKBtn+k2AnbB NuKl2a982dwvqip8j6i3IA4hqtFIW483xPlk8bOefcuwpB/lH6doEn6GrcT7iA2i2hO/ 1YTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682341617; x=1684933617; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Lx287Xzo7DZ7IW3RRrRsJADrJLhhrPWkHx34Ztc5z84=; b=dD9RVB/z3Pg3ogKUszccQhfjIHjrWdiu+8BlnjMhjFje0LVsq/FbKOo3ImkVvdL4Wq av+Fy6uDBtiEaDO3Yuh1bO9PpHj6CNeX1PJidjks+TzH6QQa87SyhKr+OKYOxMnBTXVV CD8yHlg479loxwytJH9A7GrvB0VWwH1iYyFzwKcAGp3nzUHAYuerYHhm35Ovpyp97d1o L5c8mf2q3boT9E+eYP1Z5Gnt4KrSW4OXJlsunEhhTLbXQY8y8OJ31pTFxKjWjnFKuwsY Z8p5Ei++eCymDWRbdpIu+V3jI6J/ztoHG9yavSTRJrRsfLDxrh46liiaWmh+bnVz7fkj /zkw== X-Gm-Message-State: AAQBX9c7ibYvziUs0ET9YISgXdH7dAAoFD0j4kvIX+49v06dTGnJD1Fw M8Sb3DJd2Rxp8KVa1ojxVLo8ZP81UJHzMmUprmR9ww== X-Google-Smtp-Source: AKy350YWINXy4lQxYER7LrvrEscY1KnkvioiWBZd+C24cpBwO+DpPH07x+TTP+DBQYUzzXy+72JXReZ1qTknTmcEMrE= X-Received: by 2002:a05:622a:1998:b0:3ef:26ec:f27a with SMTP id u24-20020a05622a199800b003ef26ecf27amr539720qtc.13.1682341616609; Mon, 24 Apr 2023 06:06:56 -0700 (PDT) MIME-Version: 1.0 References: <20230320172620.18254-1-james.morse@arm.com> <20230320172620.18254-3-james.morse@arm.com> In-Reply-To: <20230320172620.18254-3-james.morse@arm.com> From: Peter Newman Date: Mon, 24 Apr 2023 15:06:45 +0200 Message-ID: Subject: Re: [PATCH v3 02/19] x86/resctrl: Access per-rmid structures by index To: James Morse Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, xingxin.hx@openanolis.org, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, On Mon, Mar 20, 2023 at 6:27=E2=80=AFPM James Morse w= rote: > diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/res= ctrl/core.c > index 030d3b409768..351319403f84 100644 > --- a/arch/x86/kernel/cpu/resctrl/core.c > +++ b/arch/x86/kernel/cpu/resctrl/core.c > @@ -600,7 +600,7 @@ static void clear_closid_rmid(int cpu) > state->default_rmid =3D 0; > state->cur_closid =3D 0; > state->cur_rmid =3D 0; > - wrmsr(MSR_IA32_PQR_ASSOC, 0, 0); > + wrmsr(MSR_IA32_PQR_ASSOC, RESCTRL_RESERVED_CLOSID, 0); It looks like the RMID/CLOSID params are in the wrong order in this wrmsr()= . -Peter