From: Lin Xiulei <linxiulei@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jiri Olsa <jolsa@redhat.com>,
mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, Stephane Eranian <eranian@gmail.com>,
torvalds@linux-foundation.org, linux-perf-users@vger.kernel.org,
Brendan Gregg <brendan.d.gregg@gmail.com>,
yang_oliver@hotmail.com, jinli.zjl@alibaba-inc.com,
"leilei.lin" <leilei.lin@alibaba-inc.com>
Subject: Re: [PATCH RESEND] perf/core: Fix installing cgroup event into cpu
Date: Wed, 24 Jan 2018 15:29:34 +0800 [thread overview]
Message-ID: <CALPjY3npyVm50EpD_b_YMnj7gvFxx3SKyf5NV7t7HUBtFrgWWw@mail.gmail.com> (raw)
In-Reply-To: <20180123163737.GJ2269@hirez.programming.kicks-ass.net>
yes, you are right. In my cases, there also are some issues in
add_event_to_ctx(),
I am gonna fix it at v2
Thanks
2018-01-24 0:37 GMT+08:00 Peter Zijlstra <peterz@infradead.org>:
> On Tue, Jan 23, 2018 at 12:13:06PM +0800, linxiulei@gmail.com wrote:
>> From: "leilei.lin" <leilei.lin@alibaba-inc.com>
>>
>> Do not install cgroup event into the CPU context if the cgroup
>> is not running on this CPU
>>
>> While there is no task of cgroup running specified CPU, current
>> kernel still install cgroup event into CPU context, that causes
>> another cgroup event can't be installed into this CPU.
>>
>> Signed-off-by: leilei.lin <leilei.lin@alibaba-inc.com>
>> ---
>> kernel/events/core.c | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/kernel/events/core.c b/kernel/events/core.c
>> index 4df5b69..19c587b 100644
>> --- a/kernel/events/core.c
>> +++ b/kernel/events/core.c
>> @@ -2284,6 +2284,7 @@ static int __perf_install_in_context(void *info)
>> struct perf_event_context *ctx = event->ctx;
>> struct perf_cpu_context *cpuctx = __get_cpu_context(ctx);
>> struct perf_event_context *task_ctx = cpuctx->task_ctx;
>> + struct perf_cgroup *cgrp;
>> bool reprogram = true;
>> int ret = 0;
>>
>> @@ -2311,6 +2312,19 @@ static int __perf_install_in_context(void *info)
>> raw_spin_lock(&task_ctx->lock);
>> }
>>
>> + if (event->cgrp) {
>> + /*
>> + * Only care about cgroup events.
>> + *
>> + * If only the task belongs to cgroup of this event,
>> + * we will continue the installment
>> + */
>> + cgrp = perf_cgroup_from_task(current, ctx);
>> + if (!cgroup_is_descendant(cgrp->css.cgroup,
>> + event->cgrp->css.cgroup))
>> + goto unlock;
>> + }
>> +
>> if (reprogram) {
>> ctx_sched_out(ctx, cpuctx, EVENT_TIME);
>> add_event_to_ctx(event, ctx);
>
> I think this is wrong. You're right in that we need not schedule it not,
> but the above also completely fails to add it to the context, leading to
> it never being scheduled ever.
>
> At the very least we should do add_event_to_ctx() on it.
>
> So the only thing you can do is pick 'reprogram' or not based on if the
> current cgrp is related to the event->ctx.
next prev parent reply other threads:[~2018-01-24 7:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 4:13 [PATCH RESEND] perf/core: Fix installing cgroup event into cpu linxiulei
2018-01-23 16:37 ` Peter Zijlstra
2018-01-24 7:29 ` Lin Xiulei [this message]
2018-01-26 2:02 ` kbuild test robot
2018-01-29 3:37 ` Lin Xiulei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALPjY3npyVm50EpD_b_YMnj7gvFxx3SKyf5NV7t7HUBtFrgWWw@mail.gmail.com \
--to=linxiulei@gmail.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=brendan.d.gregg@gmail.com \
--cc=eranian@gmail.com \
--cc=jinli.zjl@alibaba-inc.com \
--cc=jolsa@redhat.com \
--cc=leilei.lin@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yang_oliver@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).