From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933440AbcLGWuC (ORCPT ); Wed, 7 Dec 2016 17:50:02 -0500 Received: from mail-vk0-f68.google.com ([209.85.213.68]:34287 "EHLO mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932583AbcLGWuA (ORCPT ); Wed, 7 Dec 2016 17:50:00 -0500 MIME-Version: 1.0 In-Reply-To: <20161207224627.GA16018@infradead.org> References: <20161207220348.8572-1-ddstreet@ieee.org> <20161207224414.GE22478@localhost.localdomain> <20161207224941.GA25959@localhost.localdomain> <20161207224627.GA16018@infradead.org> From: Dan Streetman Date: Wed, 7 Dec 2016 17:49:19 -0500 X-Google-Sender-Auth: 9cRT_Qjv9BB7FlmGL0rHx1H0q5M Message-ID: Subject: Re: [PATCH] nvme: use the correct msix vector for each queue To: Christoph Hellwig Cc: Keith Busch , Jens Axboe , Dan Streetman , linux-kernel , linux-nvme@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 7, 2016 at 5:46 PM, Christoph Hellwig wrote: > On Wed, Dec 07, 2016 at 05:49:42PM -0500, Keith Busch wrote: >> I'm just saying that blk-mq's hctx mapping will end up choosing a queue >> who's vector is mapped to a different CPU, and we don't want that. > > Right. For 4.10 we could use the pci_alloc_irq_vectors_affinity helper > to set away a pre_vector IFF we want a separate vector for the admin > queue. > >> We are currently sharing the first IO queue's interrupt vector with >> the admin queue's on purpose. Are you saying there's something wrong >> with that? > > But given that the sharing was done intentionally and we had a long > discussion on it back then there should be no real reason to change > the assignment in NVMe. sorry, i missed the past discussion. It still seems strange and obscure that it's intentional, from reading the code at least.