From: Dan Streetman <ddstreet@ieee.org>
To: Vitaly Wool <vitalywool@gmail.com>
Cc: Linux-MM <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH/RESEND v2 3/5] z3fold: extend compaction function
Date: Wed, 11 Jan 2017 11:28:48 -0500 [thread overview]
Message-ID: <CALZtONDmfWaJ2u-dO4BGnK0jztOGMEKb8WxEZ1iEurAdkMoxGA@mail.gmail.com> (raw)
In-Reply-To: <20170111160622.44ac261b12ed4778556c56dc@gmail.com>
On Wed, Jan 11, 2017 at 10:06 AM, Vitaly Wool <vitalywool@gmail.com> wrote:
> z3fold_compact_page() currently only handles the situation when
> there's a single middle chunk within the z3fold page. However it
> may be worth it to move middle chunk closer to either first or
> last chunk, whichever is there, if the gap between them is big
> enough.
>
> This patch adds the relevant code, using BIG_CHUNK_GAP define as
> a threshold for middle chunk to be worth moving.
>
> Signed-off-by: Vitaly Wool <vitalywool@gmail.com>
> ---
> mm/z3fold.c | 26 +++++++++++++++++++++++++-
> 1 file changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/mm/z3fold.c b/mm/z3fold.c
> index 98ab01f..fca3310 100644
> --- a/mm/z3fold.c
> +++ b/mm/z3fold.c
> @@ -268,6 +268,7 @@ static inline void *mchunk_memmove(struct z3fold_header *zhdr,
> zhdr->middle_chunks << CHUNK_SHIFT);
> }
>
> +#define BIG_CHUNK_GAP 3
> /* Has to be called with lock held */
> static int z3fold_compact_page(struct z3fold_header *zhdr)
> {
> @@ -286,8 +287,31 @@ static int z3fold_compact_page(struct z3fold_header *zhdr)
> zhdr->middle_chunks = 0;
> zhdr->start_middle = 0;
> zhdr->first_num++;
> + return 1;
> }
> - return 1;
> +
> + /*
> + * moving data is expensive, so let's only do that if
> + * there's substantial gain (at least BIG_CHUNK_GAP chunks)
> + */
> + if (zhdr->first_chunks != 0 && zhdr->last_chunks == 0 &&
> + zhdr->start_middle - (zhdr->first_chunks + ZHDR_CHUNKS) >=
> + BIG_CHUNK_GAP) {
> + mchunk_memmove(zhdr, zhdr->first_chunks + 1);
> + zhdr->start_middle = zhdr->first_chunks + 1;
this should be first_chunks + ZHDR_CHUNKS, not + 1.
> + return 1;
> + } else if (zhdr->last_chunks != 0 && zhdr->first_chunks == 0 &&
> + TOTAL_CHUNKS - (zhdr->last_chunks + zhdr->start_middle
> + + zhdr->middle_chunks) >=
> + BIG_CHUNK_GAP) {
> + unsigned short new_start = NCHUNKS - zhdr->last_chunks -
this should be TOTAL_CHUNKS, not NCHUNKS.
> + zhdr->middle_chunks;
> + mchunk_memmove(zhdr, new_start);
> + zhdr->start_middle = new_start;
> + return 1;
> + }
> +
> + return 0;
> }
>
> /**
> --
> 2.4.2
next prev parent reply other threads:[~2017-01-11 16:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 14:59 [PATCH/RESEND v2 0/5] z3fold optimizations and fixes Vitaly Wool
2017-01-11 15:06 ` [PATCH/RESEND v2 1/5] z3fold: make pages_nr atomic Vitaly Wool
2017-01-11 16:09 ` Dan Streetman
2017-01-11 15:06 ` [PATCH/RESEND v2 2/5] z3fold: fix header size related issues Vitaly Wool
2017-01-11 16:24 ` Dan Streetman
2017-01-11 15:06 ` [PATCH/RESEND v2 3/5] z3fold: extend compaction function Vitaly Wool
2017-01-11 16:28 ` Dan Streetman [this message]
2017-01-11 16:43 ` Vitaly Wool
2017-01-11 20:52 ` Vitaly Wool
2017-01-12 17:50 ` Dan Streetman
2017-01-11 15:06 ` [PATCH/RESEND v2 4/5] z3fold: use per-page spinlock Vitaly Wool
2017-01-11 16:42 ` Dan Streetman
2017-01-11 15:06 ` [PATCH/RESEND v2 5/5] z3fold: add kref refcounting Vitaly Wool
2017-01-11 17:08 ` Dan Streetman
2017-01-11 17:27 ` Vitaly Wool
2017-01-11 17:39 ` Dan Streetman
2017-01-11 17:51 ` Vitaly Wool
2017-01-11 18:03 ` Dan Streetman
2017-01-11 20:51 ` Vitaly Wool
2017-01-12 17:49 ` Dan Streetman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALZtONDmfWaJ2u-dO4BGnK0jztOGMEKb8WxEZ1iEurAdkMoxGA@mail.gmail.com \
--to=ddstreet@ieee.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).