From: Rob Herring <robh+dt@kernel.org>
To: Shiping Ji <shiping.linux@gmail.com>
Cc: Borislav Petkov <bp@alien8.de>, James Morse <james.morse@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-edac <linux-edac@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sasha Levin <sashal@kernel.org>,
hangl@microsoft.com, Lei Wang <lewan@microsoft.com>,
ruizhao@microsoft.com, shji@microsoft.com,
Scott Branden <scott.branden@broadcom.com>,
Yuqing Shen <yuqing.shen@broadcom.com>
Subject: Re: [PATCH v10 1/2] dt-bindings: edac: dmc-520.yaml
Date: Thu, 23 Jan 2020 07:44:32 -0600 [thread overview]
Message-ID: <CAL_Jsq+1S=mOS0-eb0=ibSn81ReDmDjrA9=bHpKC16w8B6Aq3Q@mail.gmail.com> (raw)
In-Reply-To: <09a2fe69-842f-01cf-1cfa-d5fc639b158a@gmail.com>
On Wed, Jan 22, 2020 at 6:31 PM Shiping Ji <shiping.linux@gmail.com> wrote:
>
> This is the device tree bindings for new EDAC driver dmc520_edac.c.
>
> From: Lei Wang <leiwang_git@outlook.com>
>
> Signed-off-by: Lei Wang <leiwang_git@outlook.com>
> Signed-off-by: Shiping Ji <shiping.linux@gmail.com>
> Reviewed-by: James Morse <james.morse@arm.com>
>
> ---
> Changes in v10:
> - Convert to the YAML format for binding description
>
> ---
> .../devicetree/bindings/edac/dmc-520.yaml | 56 +++++++++++++++++++
> 1 file changed, 56 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/edac/dmc-520.yaml
>
> diff --git a/Documentation/devicetree/bindings/edac/dmc-520.yaml b/Documentation/devicetree/bindings/edac/dmc-520.yaml
> new file mode 100644
> index 000000000000..dd5982b227b2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/edac/dmc-520.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: GPL-2.0
Dual license new bindings please:
(GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/edac/dmc-520.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ARM DMC-520 EDAC bindings
> +
> +maintainers:
> + - Lei Wang <lewan@microsoft.com>
> +
> +description: |+
> + DMC-520 node is defined to describe DRAM error detection and correction.
> +
> + https://static.docs.arm.com/100000/0200/corelink_dmc520_trm_100000_0200_01_en.pdf
> +
> +properties:
> + compatible:
> + items:
> + - const: brcm,dmc-520
> + - const: arm,dmc-520
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + minItems: 1
> +
> + interrupt-names:
> + minItems: 1
> + items:
> + - const: ram_ecc_errc
> + - const: ram_ecc_errd
> + - const: dram_ecc_errc
> + - const: dram_ecc_errd
> + - const: failed_access
> + - const: failed_prog
> + - const: link_err
> + - const: temperature_event
> + - const: arch_fsm
> + - const: phy_request
This defines not just the names, but the index they must be at which I
don't think you want.
minItems: 1
maxItems: 10
items:
enum:
- ram_ecc_errc
- ram_ecc_errd
...
Note the lack of '-' under 'items' making it a schema that applies to all items.
Run 'make dt_binding_check' as that would have caught this issue on the example.
Rob
next prev parent reply other threads:[~2020-01-23 13:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 0:31 [PATCH v10 1/2] dt-bindings: edac: dmc-520.yaml Shiping Ji
2020-01-23 8:23 ` Borislav Petkov
2020-01-23 16:47 ` Shiping Ji
2020-01-23 17:00 ` Borislav Petkov
2020-01-23 13:44 ` Rob Herring [this message]
2020-01-23 23:37 ` Shiping Ji
2020-01-23 13:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+1S=mOS0-eb0=ibSn81ReDmDjrA9=bHpKC16w8B6Aq3Q@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=bp@alien8.de \
--cc=devicetree@vger.kernel.org \
--cc=hangl@microsoft.com \
--cc=james.morse@arm.com \
--cc=lewan@microsoft.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=ruizhao@microsoft.com \
--cc=sashal@kernel.org \
--cc=scott.branden@broadcom.com \
--cc=shiping.linux@gmail.com \
--cc=shji@microsoft.com \
--cc=yuqing.shen@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).