From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 457E2C433E6 for ; Wed, 10 Feb 2021 21:00:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F5F764E15 for ; Wed, 10 Feb 2021 21:00:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232876AbhBJVAZ (ORCPT ); Wed, 10 Feb 2021 16:00:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:50990 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231193AbhBJVAV (ORCPT ); Wed, 10 Feb 2021 16:00:21 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 194F764DE7; Wed, 10 Feb 2021 20:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612990779; bh=8UVcBcBHgwUxXmdgoCQ0LoimmZZgbh9qAu0ypgoozQM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=O/7DHup661kD7BHH5z8EHVcdfxNpadTFO7zBNfdUcfayg7KJcoNwsnei/VmtDu/ft 1AS19f9C3h0nMWSbGTnpkesv0ACKcdsyIHojzH9BS7jm9gjm3E5ztstpUWbp7Y+fSY frQS1JoJptmgYK4O0A6BRfjqZIlt4MAshvlS/rigIUJyN+V0ZCmAFo95rCExXnBbkQ HY5CmLtckc/uf8pMorCohr9FpbWPGhAY2IrADVKhSHxkH9+3JCIndCsGOGftq3I8SB XQ2UxhFYd27xbTyjVALvg1r8pWPL8xIlpDtsM+vrm2pKVZY+zC3CnGGnd3t0s2fGU2 1Fp86/Btwq1UQ== Received: by mail-ed1-f47.google.com with SMTP id v7so4634444eds.10; Wed, 10 Feb 2021 12:59:39 -0800 (PST) X-Gm-Message-State: AOAM530fNqxxP8OqmMbiUV1IZIlYe4XfUJko0qmrJV/EBo+JeBSkcps1 YddUOJjkjNZ0HD9x7YgkLpnZ7B1tc3Y5VvGAEw== X-Google-Smtp-Source: ABdhPJxacO0wf1xtajhT6TgBmNau1cOl6EP0XT0wnGuAql3GiyYkRv8xoZQ8EpumIQDdN7LoduVFbTVtabNCICboevM= X-Received: by 2002:a50:ee10:: with SMTP id g16mr5022978eds.62.1612990777710; Wed, 10 Feb 2021 12:59:37 -0800 (PST) MIME-Version: 1.0 References: <20210210214720.02e6a6be@canb.auug.org.au> In-Reply-To: From: Rob Herring Date: Wed, 10 Feb 2021 14:59:26 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: linux-next: build failure after merge of the driver-core tree To: Saravana Kannan Cc: Greg KH , Stephen Rothwell , Linux Kernel Mailing List , Linux Next Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 2:44 PM Saravana Kannan wrote: > > On Wed, Feb 10, 2021 at 12:15 PM Rob Herring wrote: > > > > On Wed, Feb 10, 2021 at 1:17 PM Saravana Kannan wrote: > > > > > > On Wed, Feb 10, 2021 at 11:06 AM Saravana Kannan wrote: > > > > > > > > On Wed, Feb 10, 2021 at 10:18 AM Greg KH wrote: > > > > > > > > > > On Wed, Feb 10, 2021 at 09:47:20PM +1100, Stephen Rothwell wrote: > > > > > > Hi all, > > > > > > > > > > > > After merging the driver-core tree, today's linux-next build (sparc64 > > > > > > defconfig) failed like this: > > > > > > > > > > > > drivers/of/property.o: In function `parse_interrupts': > > > > > > property.c:(.text+0x14e0): undefined reference to `of_irq_parse_one' > > > > > > > > > > > > Caused by commit > > > > > > > > > > > > f265f06af194 ("of: property: Fix fw_devlink handling of interrupts/interrupts-extended") > > > > > > > > > > > > CONFIG_OF_IRQ depends on !SPARC so of_irq_parse_one() needs a stub. > > > > It's always Sparc! > > > > > > > > I have added the following patch for today. > > > > > > > > > > > > From: Stephen Rothwell > > > > > > Date: Wed, 10 Feb 2021 21:27:56 +1100 > > > > > > Subject: [PATCH] of: irq: make a stub for of_irq_parse_one() > > > > > > > > > > > > Signed-off-by: Stephen Rothwell > > > > > > --- > > > > > > include/linux/of_irq.h | 9 +++++++-- > > > > > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > > > > > Thanks Stephen! > > > > > > Actually the stub needs to return an error. 0 indicates it found the interrupt. > > > > I have a slight preference if you could add an 'if > > (!IS_ENABLED(CONFIG_OF_IRQ))' at the caller instead. > > > > If you grep of_irq_parse_one, you'll see there's only a few users > > which means it's on my hit list to make it private. Stub functions > > give the impression 'use everywhere'. > > I already sent out a fix :( Okay, it's fine. I misread Greg's mail. > Will that check optimize out the code and not cause build errors? If > so, I can send out a patch later. Yes, it will not trigger link errors. You could still get compile errors if say a struct member is ifdef'ed out. Rob