From: Rob Herring <robh@kernel.org>
To: Steen Hegelund <steen.hegelund@microchip.com>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Gregory Clement <gregory.clement@bootlin.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver
Date: Mon, 8 Feb 2021 11:00:18 -0600 [thread overview]
Message-ID: <CAL_Jsq+BsgvZMi9PaEgAG-Q=1p1TRHsOJxrSJxiHxMSQO08r1w@mail.gmail.com> (raw)
In-Reply-To: <23616bd06996c1df9480b879d804220269143f44.camel@microchip.com>
On Mon, Feb 8, 2021 at 7:20 AM Steen Hegelund
<steen.hegelund@microchip.com> wrote:
>
> Hi Rob,
>
> On Fri, 2021-02-05 at 16:35 -0600, Rob Herring wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you
> > know the content is safe
> >
> > On Wed, Jan 20, 2021 at 09:19:21AM +0100, Steen Hegelund wrote:
> > > This provides reset driver support for the Microchip Sparx5 PCB134
> > > and
> > > PCB135 reference boards.
> >
> > This isn't a compatible change. You need an explanation why that's
> > okay
> > if that's intended.
>
> I am not entirely sure that I get your point.
>
> The change (adding the reset driver) is new, and it is optional (but
> strongly recommended) for the clients to use it, so will this be a
> incompatible change?
I'm assuming something used "microchip,sparx5-chip-reset"?
> I can certainly add a an explanation. Would that be needed here in the
> bindings, or where do you suggest?
Just need to spell out why dropping that is okay in the commit msg.
But I guess what this looks like will change anyways.
Rob
next prev parent reply other threads:[~2021-02-08 18:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 8:19 [PATCH v4 0/3] Adding the Sparx5 Switch Reset Driver Steen Hegelund
2021-01-20 8:19 ` [PATCH v4 1/3] dt-bindings: reset: microchip sparx5 reset driver bindings Steen Hegelund
2021-01-20 8:19 ` [PATCH v4 2/3] reset: mchp: sparx5: add switch reset driver Steen Hegelund
2021-01-20 8:19 ` [PATCH v4 3/3] arm64: dts: reset: add microchip sparx5 " Steen Hegelund
2021-02-05 22:35 ` Rob Herring
2021-02-08 7:58 ` Steen Hegelund
2021-02-08 13:20 ` Steen Hegelund
2021-02-08 17:00 ` Rob Herring [this message]
2021-02-03 8:02 ` [PATCH v4 0/3] Adding the Sparx5 Switch Reset Driver Steen Hegelund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+BsgvZMi9PaEgAG-Q=1p1TRHsOJxrSJxiHxMSQO08r1w@mail.gmail.com' \
--to=robh@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=steen.hegelund@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).