From: Rob Herring <robh+dt@kernel.org>
To: Wan Jiabing <wanjiabing@vivo.com>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
kael_w@yeah.net
Subject: Re: [PATCH] of: Add missing of_node_put() before return
Date: Thu, 21 Apr 2022 07:34:37 -0500 [thread overview]
Message-ID: <CAL_Jsq+Ess2=+r+=+QdqkF3pQw9CS=3so86FCM8Mn_XaKBTgLA@mail.gmail.com> (raw)
In-Reply-To: <20220421122303.111766-1-wanjiabing@vivo.com>
+Thomas
On Thu, Apr 21, 2022 at 7:23 AM Wan Jiabing <wanjiabing@vivo.com> wrote:
>
> Fix the following coccicheck error:
> drivers/of/platform.c:554:2-23: WARNING: Function "for_each_node_by_type"
> should have of_node_put() before return around line 560.
Especially since the code this fixes just landed, you should Cc the
author and reference the commit.
> Early exits from for_each_node_by_type() should decrement the node
> reference counter.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/of/platform.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
This has to go via the DRM tree.
Fixes: 52b1b46c39ae ("of: Create platform devices for OF framebuffers")
Acked-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2022-04-21 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 12:23 [PATCH] of: Add missing of_node_put() before return Wan Jiabing
2022-04-21 12:34 ` Rob Herring [this message]
2022-04-21 19:34 ` kernel test robot
2022-04-21 19:54 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+Ess2=+r+=+QdqkF3pQw9CS=3so86FCM8Mn_XaKBTgLA@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kael_w@yeah.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).