From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E949FC10F14 for ; Tue, 8 Oct 2019 14:05:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3072217D7 for ; Tue, 8 Oct 2019 14:05:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570543547; bh=BSS0pP5TSRCvXx2PTe+19CYaQtXYwyol55cIo7m2kK4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=Glam6vPrVgYWMtfXJXTAxDSQr7/86D7+iwsDYBOCIOEP6PbxJTXxPiKimjMKNCISL 0tcTLJ9F14WLLFOAFi9q/JFZhHhUO28Tok8zkjwu/TQG8m7uUPcsb73lNS9deQqxp0 me/LPf+4QG9zZCC7LWERw8OIv79yOuRtWOhM8qIA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726096AbfJHOFr (ORCPT ); Tue, 8 Oct 2019 10:05:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:41492 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbfJHOFr (ORCPT ); Tue, 8 Oct 2019 10:05:47 -0400 Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 99A4D21835; Tue, 8 Oct 2019 14:05:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570543545; bh=BSS0pP5TSRCvXx2PTe+19CYaQtXYwyol55cIo7m2kK4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Kew6HNvNZ6MlVZWAgDPneJGj58ojWZM9y1SNfNv2eqWdvrpd39CXDtv/nOjRtLDTn LXMWxGOtUr6RzWSRbP6C/c7tYxmpnY1iWy38I5FhwsOEecriIePU2URkPu38dZLjKK U8f9EO4J9PpFswvfVGwK3aBM5g1z582U/JNJ652A= Received: by mail-qk1-f175.google.com with SMTP id z67so16822526qkb.12; Tue, 08 Oct 2019 07:05:45 -0700 (PDT) X-Gm-Message-State: APjAAAVBzQgXdDemSni4DIsI/PRSJlx4Yl2TmqJD1kHHli8dfMhTZ/uJ +aK9lmFkLzoWLgW/MZ+GPQWLGkmU80scqA2x3w== X-Google-Smtp-Source: APXvYqzmV2QKGWccGoICKAMKFwzAvk3BDhnCzy9bG1IFslKWjFwHSNzobfLRiSO2TBvO8XDayAdctf68UpVEJjgX+fE= X-Received: by 2002:a05:620a:7da:: with SMTP id 26mr27130717qkb.119.1570543544639; Tue, 08 Oct 2019 07:05:44 -0700 (PDT) MIME-Version: 1.0 References: <20191004151414.8458-1-krzk@kernel.org> <20191008125038.GA2550@pi3> In-Reply-To: <20191008125038.GA2550@pi3> From: Rob Herring Date: Tue, 8 Oct 2019 09:05:32 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU To: Krzysztof Kozlowski Cc: Kukjin Kim , Mark Rutland , David Airlie , Daniel Vetter , Lee Jones , Greg Kroah-Hartman , Maciej Falkowski , Marek Szyprowski , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-samsung-soc , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , dri-devel , "open list:SERIAL DRIVERS" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 8, 2019 at 7:50 AM Krzysztof Kozlowski wrote: > > On Tue, Oct 08, 2019 at 07:38:14AM -0500, Rob Herring wrote: > > On Fri, Oct 4, 2019 at 10:14 AM Krzysztof Kozlowski w= rote: > > > > > > The clkoutN names of clocks must be unique because they represent > > > unique inputs of clock multiplexer. > > > > > > Signed-off-by: Krzysztof Kozlowski > > > --- > > > Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 6 ++++-- > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b= /Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > index 73b56fc5bf58..d8e03716f5d2 100644 > > > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > @@ -53,8 +53,10 @@ properties: > > > List of clock names for particular CLKOUT mux inputs > > > minItems: 1 > > > maxItems: 32 > > > - items: > > > - pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > > + allOf: > > > + - items: > > > + pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > > + - uniqueItems: true > > > > You shouldn't need the 'allOf', just add uniqueItems at the same level = as items. > > If you mean something like: > 56 uniqueItems: true > 57 items: > 58 pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > Then the dt_binding_check fails: > > dev/linux/Documentation/devicetree/bindings/arm/samsung/pmu.yaml: propert= ies:clock-names: > 'uniqueItems' is not one of ['$ref', 'additionalItems', 'additionalProper= ties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'd= eprecated', 'description', 'else', 'enum', 'items', 'if', 'minItems', 'mini= mum', 'maxItems', 'maximum', 'not', 'oneOf', 'pattern', 'patternProperties'= , 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedPropert= ies'] I can add it. The other option is to fix this in the clock schema. I'm not sure if there's a need for duplicate clock-names. Seems unlikely. I'll test that. Rob