From: Rob Herring <robh+dt@kernel.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: Frank Rowand <frowand.list@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 2/2] of: Add array read functions with min/max size limits
Date: Thu, 8 Sep 2016 10:38:09 -0500 [thread overview]
Message-ID: <CAL_Jsq+Rdw041Xnf8JRocozjeiOCDFaPcAQFM+emjeyrE4W=Jg@mail.gmail.com> (raw)
In-Reply-To: <1473348852.4359.18.camel@rf-debian.wolfsonmicro.main>
On Thu, Sep 8, 2016 at 10:34 AM, Richard Fitzgerald
<rf@opensource.wolfsonmicro.com> wrote:
> On Thu, 2016-09-08 at 09:46 -0500, Rob Herring wrote:
>> On Tue, Sep 6, 2016 at 10:02 AM, Richard Fitzgerald
>> <rf@opensource.wolfsonmicro.com> wrote:
>> > Add a new set of array reading functions that take a minimum and
>> > maximum size limit and will fail if the property size is not within
>> > the size limits. This makes it more convenient for drivers that
>> > use variable-size DT arrays which must be bounded at both ends -
>> > data must be at least N entries but must not overflow the array
>> > it is being copied into. It is also more efficient than making this
>> > functionality out of existing public functions and avoids duplication.
>> >
>> > The existing array functions have been left in the API, since there
>> > are a very large number of clients of those functions and their
>> > existing functionality is still useful. This avoids turning a small
>> > API improvement into a major kernel rework.
[...]
>> > @@ -1229,21 +1270,53 @@ EXPORT_SYMBOL_GPL(of_property_read_u32_index);
>> > int of_property_read_u8_array(const struct device_node *np,
>> > const char *propname, u8 *out_values, size_t sz)
>> > {
>> > - const u8 *val = of_find_property_value_of_size(np, propname,
>> > - (sz * sizeof(*out_values)),
>> > - 0,
>> > - NULL);
>> > -
>> > - if (IS_ERR(val))
>> > - return PTR_ERR(val);
>> > -
>> > - while (sz--)
>> > - *out_values++ = *val++;
>> > - return 0;
>> > + return of_property_read_variable_u8_array(np, propname, out_values,
>> > + sz, 0);
>>
>> This should be min and max both set to sz.
>
> Passing 0 as max preserves the existing behaviour of these functions of
> only requiring the array to be at least sz long, but not caring if it's
> longer.
Yes, I was just writing to say that after reading patch 1 more carefully.
Rob
next prev parent reply other threads:[~2016-09-08 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 15:02 [PATCH 1/2] of: Make of_find_property_value_of_size take a length range Richard Fitzgerald
2016-09-06 15:02 ` [PATCH 2/2] of: Add array read functions with min/max size limits Richard Fitzgerald
2016-09-08 14:46 ` Rob Herring
2016-09-08 15:34 ` Richard Fitzgerald
2016-09-08 15:38 ` Rob Herring [this message]
2016-09-08 15:46 ` Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+Rdw041Xnf8JRocozjeiOCDFaPcAQFM+emjeyrE4W=Jg@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).