From: Rob Herring <robherring2@gmail.com>
To: Dov Levenglick <dovl@codeaurora.org>
Cc: Yaniv Gardi <ygardi@codeaurora.org>,
Akinobu Mita <akinobu.mita@gmail.com>,
merez@qti.qualcomm.com, dovl@qti.qualcomm.com,
Jej B <james.bottomley@hansenpartnership.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-scsi@vger.kernel.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Santosh Y <santoshsy@gmail.com>,
linux-scsi-owner@vger.kernel.org,
Subhash Jadavani <subhashj@codeaurora.org>,
Paul Bolle <pebolle@tiscali.nl>,
Gilad Broner <gbroner@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <jbottomley@odin.com>,
Dolev Raviv <draviv@codeaurora.org>,
Christoph Hellwig <hch@lst.de>,
Sujit Reddy Thumma <sthumma@codeaurora.org>,
Raviv Shvili <rshvili@codeaurora.org>,
Sahitya Tummala <stummala@codeaurora.org>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device
Date: Tue, 9 Jun 2015 07:53:28 -0500 [thread overview]
Message-ID: <CAL_Jsq+SWq9=xTjVvQH2tMoq=g_rjk44A7T4TMFKvDiUp_ahCg@mail.gmail.com> (raw)
In-Reply-To: <bfade46f9d953e10240acb835105b81d.squirrel@www.codeaurora.org>
On Tue, Jun 9, 2015 at 12:53 AM, Dov Levenglick <dovl@codeaurora.org> wrote:
>> On Sun, Jun 7, 2015 at 10:32 AM, <ygardi@codeaurora.org> wrote:
>>>> 2015-06-05 5:53 GMT+09:00 <ygardi@codeaurora.org>:
[...]
>>> If ufshcd-pltfrm driver is loaded before ufs-qcom, (what actually
>>> happens
>>> always), then the calling to of_platform_populate() which is added,
>>> guarantees that ufs-qcom probe will be called and finish, before
>>> ufshcd_pltfrm probe continues.
>>> so ufs_variant device is always there, and ready.
>>> I think it means we are safe - since either way, we make sure ufs-qcom
>>> probe will be called and finish before dealing with ufs_variant device
>>> in
>>> ufshcd_pltfrm probe.
>>
>> This is due to the fact that you have 2 platform drivers. You should
>> only have 1 (and 1 node). If you really think you need 2, then you
>> should do like many other common *HCIs do and make the base UFS driver
>> a set of library functions that drivers can use or call. Look at EHCI,
>> AHCI, SDHCI, etc. for inspiration.
>
> Hi Rob,
> We did look at SDHCI and decided to go with this design due to its
> simplicity and lack of library functions. Yaniv described the proper flow
> of probing and, as we understand things, it is guaranteed to work as
> designed.
>
> Furthermore, the design of having a subcore in the dts is used in the
> Linux kernel. Please have a look at drivers/usb/dwc3 where - as an example
> - both dwc3-msm and dwc3-exynox invoke the probing function in core.c
> (i.e. the shared underlying Synopsys USB dwc3 core) by calling
> of_platform_populate().
That binding has the same problem. Please don't propagate that. There
is no point in a sub-node in this case.
> Do you see a benefit in the SDHCi implementation?
Yes, it does not let the kernel driver design dictate the hardware description.
Rob
next prev parent reply other threads:[~2015-06-09 12:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-03 9:37 [PATCH v2 0/4] fixing building errors and warnings when components Yaniv Gardi
2015-06-03 9:37 ` [PATCH v2 1/4] phy: qcom-ufs: fix build error when the component is built as a module Yaniv Gardi
2015-06-03 9:37 ` [PATCH v2 2/4] scsi: ufs-qcom: fix compilation warning if compiled " Yaniv Gardi
2015-06-03 9:37 ` [PATCH v2 3/4] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component Yaniv Gardi
2015-06-03 9:37 ` [PATCH v2 4/4] scsi: ufs: probe and init of variant driver from the platform device Yaniv Gardi
2015-06-04 14:07 ` Paul Bolle
2015-06-04 14:42 ` Paul Bolle
2015-06-04 20:42 ` ygardi
2015-06-07 15:22 ` ygardi
2015-06-04 14:32 ` Akinobu Mita
2015-06-04 20:53 ` ygardi
2015-06-05 16:47 ` Akinobu Mita
2015-06-07 15:32 ` ygardi
2015-06-08 14:47 ` Akinobu Mita
2015-06-08 15:02 ` Rob Herring
2015-06-09 5:53 ` Dov Levenglick
2015-06-09 12:53 ` Rob Herring [this message]
2015-06-17 7:42 ` Dov Levenglick
2015-06-17 12:46 ` Rob Herring
2015-06-17 13:17 ` Dov Levenglick
2015-06-17 13:37 ` Rob Herring
2015-06-17 14:21 ` Dov Levenglick
2015-06-17 14:31 ` James Bottomley
2015-06-17 14:38 ` Dov Levenglick
2015-06-08 14:51 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+SWq9=xTjVvQH2tMoq=g_rjk44A7T4TMFKvDiUp_ahCg@mail.gmail.com' \
--to=robherring2@gmail.com \
--cc=akinobu.mita@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dovl@codeaurora.org \
--cc=dovl@qti.qualcomm.com \
--cc=draviv@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=gbroner@codeaurora.org \
--cc=hch@lst.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=james.bottomley@hansenpartnership.com \
--cc=jbottomley@odin.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=merez@qti.qualcomm.com \
--cc=pawel.moll@arm.com \
--cc=pebolle@tiscali.nl \
--cc=robh+dt@kernel.org \
--cc=rshvili@codeaurora.org \
--cc=santoshsy@gmail.com \
--cc=sthumma@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).