From: Rob Herring <robh+dt@kernel.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Gustavo Padovan <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
Pavel Machek <pavel@ucw.cz>, Tony Lindgren <tony@atomide.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Mark Rutland <mark.rutland@arm.com>,
"open list:BLUETOOTH DRIVERS" <linux-bluetooth@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 09/11] Bluetooth: add nokia driver
Date: Wed, 22 Mar 2017 16:26:28 -0500 [thread overview]
Message-ID: <CAL_Jsq+UXxocmpSJwJ8dVY0ZSLn1Rk+GfTRKP7Wqvo-_cE4qPg@mail.gmail.com> (raw)
In-Reply-To: <20170321223216.11733-10-sre@kernel.org>
On Tue, Mar 21, 2017 at 5:32 PM, Sebastian Reichel <sre@kernel.org> wrote:
> This adds a driver for the Nokia H4+ protocol, which is used
> at least on the Nokia N9, N900 & N950.
>
> Signed-off-by: Sebastian Reichel <sre@kernel.org>
> ---
> + btdev->wakeup_host = devm_gpiod_get(dev, "host-wakeup", GPIOD_IN);
> + if (IS_ERR(btdev->wakeup_host)) {
> + err = PTR_ERR(btdev->wakeup_host);
> + dev_err(dev, "could not get host wakeup gpio: %d", err);
> + return err;
> + }
> +
> + btdev->wake_irq = gpiod_to_irq(btdev->wakeup_host);
Missed this in the binding review, but generally, we make these
interrupts rather than gpios in the binding.
> +
> + err = devm_request_threaded_irq(dev, btdev->wake_irq, NULL,
> + wakeup_handler,
> + IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
> + "wakeup", btdev);
> + if (err) {
> + dev_err(dev, "could request wakeup irq: %d", err);
> + return err;
> + }
next prev parent reply other threads:[~2017-03-22 21:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 22:32 [PATCHv2 00/11] Nokia H4+ support Sebastian Reichel
2017-03-21 22:32 ` [PATCHv2 01/11] Bluetooth: hci_uart: add support for word alignment Sebastian Reichel
2017-03-21 22:32 ` [PATCHv2 02/11] Bluetooth: hci_uart: add serdev driver support library Sebastian Reichel
2017-03-22 9:32 ` Pavel Machek
2017-03-21 22:32 ` [PATCHv2 03/11] Bluetooth: hci_serdev: do not open device in hci open Sebastian Reichel
2017-03-21 22:32 ` [PATCHv2 04/11] tty: serial: omap: add UPF_BOOT_AUTOCONF flag for DT init Sebastian Reichel
2017-03-22 9:32 ` Pavel Machek
2017-03-21 22:32 ` [PATCHv2 05/11] serdev: add serdev_device_wait_until_sent Sebastian Reichel
2017-03-22 9:39 ` Pavel Machek
2017-03-21 22:32 ` [PATCHv2 06/11] serdev: implement get/set tiocm Sebastian Reichel
2017-03-22 0:58 ` [PATCHv2.1] " Sebastian Reichel
2017-03-22 9:40 ` Pavel Machek
2017-03-22 21:18 ` Rob Herring
2017-03-21 22:32 ` [PATCHv2 07/11] serdev: add helpers for cts and rts handling Sebastian Reichel
2017-03-22 21:03 ` Rob Herring
2017-03-21 22:32 ` [PATCHv2 08/11] dt-bindings: net: bluetooth: Add nokia-bluetooth Sebastian Reichel
2017-03-22 21:04 ` Rob Herring
2017-03-21 22:32 ` [PATCHv2 09/11] Bluetooth: add nokia driver Sebastian Reichel
2017-03-22 21:26 ` Rob Herring [this message]
2017-03-22 22:48 ` Sebastian Reichel
2017-03-23 7:50 ` Frédéric Danis
2017-03-23 9:07 ` Sebastian Reichel
2017-03-21 22:32 ` [PATCHv2 10/11] ARM: dts: N900: Add bluetooth Sebastian Reichel
2017-03-22 21:06 ` Rob Herring
2017-03-22 23:55 ` Tony Lindgren
2017-03-21 22:32 ` [PATCHv2 11/11] ARM: dts: N9/N950: add bluetooth Sebastian Reichel
2017-03-22 21:06 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+UXxocmpSJwJ8dVY0ZSLn1Rk+GfTRKP7Wqvo-_cE4qPg@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=jslaby@suse.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=samuel.thibault@ens-lyon.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).