From: Rob Herring <robh@kernel.org>
To: Steven Price <steven.price@arm.com>
Cc: Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/panfrost: Remove NULL check for regulator
Date: Wed, 9 Oct 2019 13:40:28 -0500 [thread overview]
Message-ID: <CAL_Jsq+WveA27wtuHgW+AbAG69x3gEL4LNLtiqS48tCDyJuWJQ@mail.gmail.com> (raw)
In-Reply-To: <20191004144413.42586-1-steven.price@arm.com>
On Fri, Oct 4, 2019 at 9:44 AM Steven Price <steven.price@arm.com> wrote:
>
> devm_regulator_get() is used to populate pfdev->regulator which ensures
> that this cannot be NULL (a dummy regulator will be returned if
> necessary). So remove the check in panfrost_devfreq_target().
>
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
> This looks like it was accidentally reintroduced by the merge from
> drm-next into drm-misc-next due to the duplication of "drm/panfrost: Add
> missing check for pfdev-regulator" (commits c90f30812a79 and
> 52282163dfa6).
> ---
> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Applied, thanks.
Rob
prev parent reply other threads:[~2019-10-09 18:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-04 14:44 [PATCH] drm/panfrost: Remove NULL check for regulator Steven Price
2019-10-09 18:40 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+WveA27wtuHgW+AbAG69x3gEL4LNLtiqS48tCDyJuWJQ@mail.gmail.com \
--to=robh@kernel.org \
--cc=airlied@linux.ie \
--cc=alyssa.rosenzweig@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=steven.price@arm.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).