From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752036AbdLEVWU (ORCPT ); Tue, 5 Dec 2017 16:22:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:38464 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751323AbdLEVWJ (ORCPT ); Tue, 5 Dec 2017 16:22:09 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4962B2199D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=robh+dt@kernel.org X-Google-Smtp-Source: AGs4zMYUQm9df24kL9Qu/5lcRrgjTW4ONVM1iqq/SnM8HIxXkVxl4f9wu5//tQ02xmd+r4bBYy+vIIO+ID1tHWRqSoo= MIME-Version: 1.0 In-Reply-To: <1512493493-6464-5-git-send-email-okaya@codeaurora.org> References: <1512493493-6464-1-git-send-email-okaya@codeaurora.org> <1512493493-6464-5-git-send-email-okaya@codeaurora.org> From: Rob Herring Date: Tue, 5 Dec 2017 15:21:46 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V6 4/7] OF: properties: Implement get_match_data() callback To: Sinan Kaya Cc: "open list:DMA GENERIC OFFLOAD ENGINE SUBSYSTEM" , Timur Tabi , "devicetree@vger.kernel.org" , "linux-acpi@vger.kernel.org" , linux-arm-msm , "linux-arm-kernel@lists.infradead.org" , Frank Rowand , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 5, 2017 at 11:04 AM, Sinan Kaya wrote: > Now that we have a get_match_data() callback as part of the firmware node, > implement the OF specific piece for it. > > Signed-off-by: Sinan Kaya > --- > drivers/of/property.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/of/property.c b/drivers/of/property.c > index 264c355..9964169 100644 > --- a/drivers/of/property.c > +++ b/drivers/of/property.c > @@ -981,6 +981,12 @@ static int of_fwnode_graph_parse_endpoint(const struct fwnode_handle *fwnode, > return 0; > } > > +void *of_fwnode_get_match_data(const struct fwnode_handle *fwnode, Should be static. With that, for patches 3 and 4: Reviewed-by: Rob Herring > + struct device *dev) > +{ > + return (void *)of_device_get_match_data(dev); > +} > + > const struct fwnode_operations of_fwnode_ops = { > .get = of_fwnode_get, > .put = of_fwnode_put, > @@ -996,5 +1002,6 @@ static int of_fwnode_graph_parse_endpoint(const struct fwnode_handle *fwnode, > .graph_get_remote_endpoint = of_fwnode_graph_get_remote_endpoint, > .graph_get_port_parent = of_fwnode_graph_get_port_parent, > .graph_parse_endpoint = of_fwnode_graph_parse_endpoint, > + .get_match_data = of_fwnode_get_match_data, > }; > EXPORT_SYMBOL_GPL(of_fwnode_ops); > -- > 1.9.1 >